[DBIx-Class-Devel] [dbsrgits/dbix-class] Treat undef like blessed objects for the purpose of looking for special handling (#106)

[Peter Rabbitson]

Hi, and thank you for the report/patch!

A similar problem was reported couple weeks earlier, I haven't gotten around to looking at the other report yet: I am hoping to be able to do so in 2~3 days from now.

Your fix *seems* incorrect: it kinda sorta feels like you should be doing the cache invalidation at the right spot, instead of giving `undef` *inflated* status (which is likely to mess with other logic N steps removed). I can not put my finger on it yet, but then I haven't dug too deep.

Unrelated and regardless of the above: DBIC is at a stage of its life where single line fixes like the proposed can no longer be applied without an accompanying *fails before / doesn't fail after* test. While I am busy elsewhere, could you please put an addition to a file of your choice in `t/icdt/*` that will exercise the changeset in question?

Thank you!

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/dbix-class/pull/106#issuecomment-228951877
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20160627/961671b9/attachment.htm>