[DBIx-Class-Devel] [dbix-class] Avoid infinite loop calling svp_release() (#97)

Paul Mooney notifications at github.com
Thu Mar 10 11:18:25 GMT 2016


We hit a bug in our tests when we rolled back twice to the same savepoint. Although this was our bug we only found out when the test never never completed and used much CPU on a Jenkins box.

You can view, comment on, or merge this pull request online at:

  https://github.com/dbsrgits/dbix-class/pull/97

-- Commit Summary --

  * Avoid infinite loop if save point does not exist
  * make sure we pop the savepoint off the stack
  * Really really fail if the savepoint is not on the stack

-- File Changes --

    M lib/DBIx/Class/Storage.pm (8)

-- Patch Links --

https://github.com/dbsrgits/dbix-class/pull/97.patch
https://github.com/dbsrgits/dbix-class/pull/97.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/dbix-class/pull/97
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20160310/daae63fd/attachment.htm>


More information about the DBIx-Class-Devel mailing list