No subject

the UNIQUE constraint would win in any case.</p>
<p>Even worse any INSERT, UPDATE or DELETE operation would need to maintain<br>
the index which is never used. This does not sound sensible to me.</p>
<p>The supposed patch avoids the adding of those indices if the column is<br>
checked if it is <em>the first column</em> of a UNIQUE constraint. If it's not<br>
the index is added, if it is the first column it is handled like a<br>
primary key.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>&nbsp;&nbsp;<a href='https://github.com/dbsrgits/dbix-class/pull/113'>https://github.com/dbsrgits/dbix-class/pull/113</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>fix: Don&#39;t add indices on columns with UNIQUE constraint</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/dbsrgits/dbix-class/pull/113/files#diff-0">lib/SQL/Translator/Parser/DBIx/Class.pm</a>
    (10)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/dbsrgits/dbix-class/pull/113/files#diff-1">t/86sqlt.t</a>
    (17)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/dbsrgits/dbix-class/pull/113/files#diff-2">t/99dbic_sqlt_parser.t</a>
    (2)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/dbsrgits/dbix-class/pull/113/files#diff-3">t/lib/sqlite.sql</a>
    (4)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/dbsrgits/dbix-class/pull/113.patch'>https://github.com/dbsrgits/dbix-class/pull/113.patch</a></li>
  <li><a href='https://github.com/dbsrgits/dbix-class/pull/113.diff'>https://github.com/dbsrgits/dbix-class/pull/113.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/dbsrgits/dbix-class/pull/113">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AASeAn-92qYdYr263ya16Sfw53ZjgLuwks5rZLuIgaJpZM4L3N_w">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AASeArcrZ4wuf42RxS6s6i-9S61R2bowks5rZLuIgaJpZM4L3N_w.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/dbsrgits/dbix-class/pull/113"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/dbsrgits/dbix-class","title":"dbsrgits/dbix-class","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/dbsrgits/dbix-class"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"fix: Don't add indices on columns with UNIQUE constraint (#113)"}],"action":{"name":"View Pull Request","url":"https://github.com/dbsrgits/dbix-class/pull/113"}}}</script>

----==_mimepart_5896158812d36_6f843fb1a755b13828822f--