[DBIx-Class-Devel] [dbsrgits/dbix-class] Stop trying to get last_insert_id() from all the columns (#122)

[Vladimir Melnik]

Hello,

When we're trying to create a new row in a table having a complex PK (like `int+datetime+datetime` in my case), we're getting a `Can't get last insert id` exception, as datetime doesn't return anything to a `last_insert_id` call, so `@pri_values != @missing_pri` in such case.

So I'd like to propose to filter out the columns that don't have the `is_auto_increment` attribute set. Would you be so kind as to review it? Thanks!
You can view, comment on, or merge this pull request online at:

  https://github.com/dbsrgits/dbix-class/pull/122

-- Commit Summary --

  * Stop trying to get last_insert_id() from all the columns

-- File Changes --

    M lib/DBIx/Class/Storage/DBI.pm (2)

-- Patch Links --

https://github.com/dbsrgits/dbix-class/pull/122.patch
https://github.com/dbsrgits/dbix-class/pull/122.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/dbix-class/pull/122
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20171115/726cf87d/attachment.htm>