[DBIx-Class-Devel] [dbsrgits/dbix-class] use base before namespace::clean (#114)

[Graham Knop]

namespace::clean uses the hints hash to track when it should do its
work.  Without extra protection, using hints across nested module
loads can crash on perl <= 5.8.3.  Older versions of base.pm used a
string eval, which served to provide the isolation needed to avoid the
bug.

Moving the use base before the use namespace::clean means the hints
aren't used until after the other modules are loaded, which avoids this
issue.

An alternate workaround would involve localizing the hints, but this
involves intercepting the module loads.  This would mean using something
like Module::Runtime or Lexical::SealRequireHints, although those modules
don't currently provide the localization needed to workaround this
specific issue.
You can view, comment on, or merge this pull request online at:

  https://github.com/dbsrgits/dbix-class/pull/114

-- Commit Summary --

  * use base before namespace::clean

-- File Changes --

    M lib/DBIx/Class/CDBICompat/LiveObjectIndex.pm (3)
    M lib/DBIx/Class/Storage/DBI/Sybase.pm (3)
    M lib/DBIx/Class/Storage/DBI/Sybase/MSSQL.pm (3)
    M lib/SQL/Translator/Parser/DBIx/Class.pm (3)

-- Patch Links --

https://github.com/dbsrgits/dbix-class/pull/114.patch
https://github.com/dbsrgits/dbix-class/pull/114.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/dbix-class/pull/114
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20171016/90073eb4/attachment.htm>