[DBIx-Class-Devel] [Perl5/DBIx-Class] Use deep merge for column info when adding columns (#128)

[Robert Rothenberg]

The add_columns method uses a shallow merge of column
information.  But the problem is that information in
"extra" is overwritten rather than merged.

This fixes the following issue:

    __PACKAGE__->add_column(
      x => {
        data_type => 'enum',
        extra     => {
          list => [qw/ success fail /],
        }
      }
    );

    __PACKAGE__->add_column(
      '+x' => {
        extra => {
          something_else => ...
        }
      }
    );
You can view, comment on, or merge this pull request online at:

  https://github.com/Perl5/DBIx-Class/pull/128

-- Commit Summary --

  * Use deep merge for column info when adding columns

-- File Changes --

    M lib/DBIx/Class/ResultSource.pm (3)

-- Patch Links --

https://github.com/Perl5/DBIx-Class/pull/128.patch
https://github.com/Perl5/DBIx-Class/pull/128.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/Perl5/DBIx-Class/pull/128
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20180730/a39d6206/attachment.htm>