From notifications at github.com Tue Feb 5 12:46:36 2019 From: notifications at github.com (codecov[bot]) Date: Tue, 05 Feb 2019 04:46:36 -0800 Subject: [DBIx-Class-Devel] [dbsrgits/sql-translator] Add index length option for MySQL (#68) In-Reply-To: References: Message-ID: # [Codecov](https://codecov.io/gh/dbsrgits/sql-translator/pull/68?src=pr&el=h1) Report > Merging [#68](https://codecov.io/gh/dbsrgits/sql-translator/pull/68?src=pr&el=desc) into [master](https://codecov.io/gh/dbsrgits/sql-translator/commit/86c68a0f3f41305f6ce2d7ad1a4f9edc010c2b99?src=pr&el=desc) will **increase** coverage by `0.06%`. > The diff coverage is `91.3%`. [![Impacted file tree graph](https://codecov.io/gh/dbsrgits/sql-translator/pull/68/graphs/tree.svg?width=650&token=vX72SYSHzm&height=150&src=pr)](https://codecov.io/gh/dbsrgits/sql-translator/pull/68?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #68 +/- ## ========================================== + Coverage 21.5% 21.57% +0.06% ========================================== Files 71 71 Lines 19914 19930 +16 Branches 5728 5741 +13 ========================================== + Hits 4283 4299 +16 + Misses 14922 14921 -1 - Partials 709 710 +1 ``` | [Impacted Files](https://codecov.io/gh/dbsrgits/sql-translator/pull/68?src=pr&el=tree) | Coverage ? | | |---|---|---| | [lib/SQL/Translator/Schema/Index.pm](https://codecov.io/gh/dbsrgits/sql-translator/pull/68/diff?src=pr&el=tree#diff-bGliL1NRTC9UcmFuc2xhdG9yL1NjaGVtYS9JbmRleC5wbQ==) | `91.66% (?)` | :arrow_up: | | [lib/SQL/Translator/Producer/HTML.pm](https://codecov.io/gh/dbsrgits/sql-translator/pull/68/diff?src=pr&el=tree#diff-bGliL1NRTC9UcmFuc2xhdG9yL1Byb2R1Y2VyL0hUTUwucG0=) | `50.58% <0%> (?)` | :arrow_up: | | [lib/SQL/Translator/Producer/DB2.pm](https://codecov.io/gh/dbsrgits/sql-translator/pull/68/diff?src=pr&el=tree#diff-bGliL1NRTC9UcmFuc2xhdG9yL1Byb2R1Y2VyL0RCMi5wbQ==) | `83% <0%> (-0.84%)` | :arrow_down: | | [lib/SQL/Translator/Producer/SQLite.pm](https://codecov.io/gh/dbsrgits/sql-translator/pull/68/diff?src=pr&el=tree#diff-bGliL1NRTC9UcmFuc2xhdG9yL1Byb2R1Y2VyL1NRTGl0ZS5wbQ==) | `86.11% <100%> (+0.19%)` | :arrow_up: | | [lib/SQL/Translator/Producer/MySQL.pm](https://codecov.io/gh/dbsrgits/sql-translator/pull/68/diff?src=pr&el=tree#diff-bGliL1NRTC9UcmFuc2xhdG9yL1Byb2R1Y2VyL015U1FMLnBt) | `90.52% <100%> (?)` | :arrow_up: | | [lib/SQL/Translator/Generator/DDL/SQLServer.pm](https://codecov.io/gh/dbsrgits/sql-translator/pull/68/diff?src=pr&el=tree#diff-bGliL1NRTC9UcmFuc2xhdG9yL0dlbmVyYXRvci9EREwvU1FMU2VydmVyLnBt) | `90.47% <100%> (+3.37%)` | :arrow_up: | | [lib/SQL/Translator/Role/ListAttr.pm](https://codecov.io/gh/dbsrgits/sql-translator/pull/68/diff?src=pr&el=tree#diff-bGliL1NRTC9UcmFuc2xhdG9yL1JvbGUvTGlzdEF0dHIucG0=) | `100% <100%> (?)` | :arrow_up: | | [lib/SQL/Translator/Producer/Oracle.pm](https://codecov.io/gh/dbsrgits/sql-translator/pull/68/diff?src=pr&el=tree#diff-bGliL1NRTC9UcmFuc2xhdG9yL1Byb2R1Y2VyL09yYWNsZS5wbQ==) | `69.75% <100%> (+0.1%)` | :arrow_up: | | [lib/SQL/Translator/Utils.pm](https://codecov.io/gh/dbsrgits/sql-translator/pull/68/diff?src=pr&el=tree#diff-bGliL1NRTC9UcmFuc2xhdG9yL1V0aWxzLnBt) | `68.65% <100%> (+1.21%)` | :arrow_up: | | [lib/SQL/Translator/Producer/Sybase.pm](https://codecov.io/gh/dbsrgits/sql-translator/pull/68/diff?src=pr&el=tree#diff-bGliL1NRTC9UcmFuc2xhdG9yL1Byb2R1Y2VyL1N5YmFzZS5wbQ==) | `68.7% <100%> (-0.53%)` | :arrow_down: | | ... and [2 more](https://codecov.io/gh/dbsrgits/sql-translator/pull/68/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/dbsrgits/sql-translator/pull/68?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `? = absolute (impact)`, `? = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/dbsrgits/sql-translator/pull/68?src=pr&el=footer). Last update [86c68a0...0d987f2](https://codecov.io/gh/dbsrgits/sql-translator/pull/68?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dbsrgits/sql-translator/pull/68#issuecomment-460625219 -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Feb 5 22:45:40 2019 From: notifications at github.com (fabzzap) Date: Tue, 05 Feb 2019 22:45:40 +0000 (UTC) Subject: [DBIx-Class-Devel] [dbsrgits/sql-abstract] Do not generate incorrect SQL in presence of -and=>[] (#15) In-Reply-To: References: Message-ID: @fabzzap pushed 1 commit. 3e759b172be1eff4fd73a5f2fc9c04027f12eead Add a test about generated SQL in presence of "-and=>[]" -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/dbsrgits/sql-abstract/pull/15/files/65d201415d77d0caeacd0a463ada42478f9275ae..3e759b172be1eff4fd73a5f2fc9c04027f12eead -------------- next part -------------- An HTML attachment was scrubbed... URL: From notifications at github.com Tue Feb 5 22:49:26 2019 From: notifications at github.com (fabzzap) Date: Tue, 05 Feb 2019 22:49:26 +0000 (UTC) Subject: [DBIx-Class-Devel] [dbsrgits/sql-abstract] Do not generate incorrect SQL in presence of -and=>[] (#15) In-Reply-To: References: Message-ID: I just pushed a test for the patch. I don't know what "silently drop[s] things" here. `-and=>[]` is supposed to have no effect, but the main code instead generates a warning and incorrect SQL. With the patch, it behaves correctly: it does nothing. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/dbsrgits/sql-abstract/pull/15#issuecomment-460835549 -------------- next part -------------- An HTML attachment was scrubbed... URL: