[DBIx-Class-Devel] [dbsrgits/sql-abstract] Hashref bind values in insert() no longer cause a warning (#18)

Sebastian Riedel notifications at github.com
Fri Nov 22 23:59:51 GMT 2019


This is a fairly simple change. When this warning was added [11 years ago](https://github.com/kraih/sql-abstract/commit/5db47f9fe6d06048b35092378a04e3a292d03a19) we didn't know relational databases would be using JSON in 2019. But now we do know there are very valid use cases for hashrefs in bind values. The feature is already used in [Mojo::Pg](https://metacpan.org/pod/Mojo::Pg::Database#insert), and judging by discussions on IRC there are plans to have native support for JSON in `DBD::Pg` at some point in the future. So i believe this deprecation should be reverted.
You can view, comment on, or merge this pull request online at:

  https://github.com/dbsrgits/sql-abstract/pull/18

-- Commit Summary --

  * Hashref bind values in insert() no longer cause a warning

-- File Changes --

    M lib/SQL/Abstract.pm (5)
    M t/01generate.t (5)

-- Patch Links --

https://github.com/dbsrgits/sql-abstract/pull/18.patch
https://github.com/dbsrgits/sql-abstract/pull/18.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/sql-abstract/pull/18
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20191122/5e96e210/attachment.htm>


More information about the DBIx-Class-Devel mailing list