[DBIx-Class-Devel] [dbsrgits/sql-translator] Oracle producer add missing functions (PR #143)

hazardv notifications at github.com
Thu Sep 29 13:31:22 GMT 2022


@hazardv commented on this pull request.



> @@ -489,7 +489,17 @@ parens_name_list : '(' NAME(s /,/) ')'
 field_meta : default_val
     | column_constraint
 
-default_val  : /default/i VALUE
+default_val  : 
+    /default/i CURRENT_TIMESTAMP

I handled it that way because of how it was handled for MySQL and CURRENT_TIMESTAMP is handled the same way by Oracle and MySQL databases. This is my first time looking at the parser syntax and its quite confusing so I tried to keep the changes as simple and as close to what I could understand as possible.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/sql-translator/pull/143#discussion_r983547302
You are receiving this because you are subscribed to this thread.

Message ID: <dbsrgits/sql-translator/pull/143/review/1125304791 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20220929/a00c85c6/attachment.htm>


More information about the DBIx-Class-Devel mailing list