[DBIx-Class-Devel] [dbsrgits/sql-translator] Add index length option for MySQL (#68)

Veesh Goldman notifications at github.com
Mon Jun 19 20:05:43 GMT 2023


Yeah, i don't really like this approach so much; index prefix length is a database dependent feature - the handling for that should be in the databases that support it, not in the abstract class.

i also don't like the fact that this change bleeds everywhere all over the code; i would go further than @nrdvana and say that `fields` should continue returning just the name of the field, and there should be a separate `field_info` method or something for that auxiallary info.

In fact, `field_info` or whatever should always return hashes, so we never have to deal with mixed lists.

I'm gonna give this a crack

-- 
Reply to this email directly or view it on GitHub:
https://github.com/dbsrgits/sql-translator/pull/68#issuecomment-1597700087
You are receiving this because you are subscribed to this thread.

Message ID: <dbsrgits/sql-translator/pull/68/c1597700087 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.scsys.co.uk/pipermail/dbix-class-devel/attachments/20230619/caaad540/attachment.htm>


More information about the DBIx-Class-Devel mailing list