<p>Sorry to disappoint, but this pull request is a no-go. <code>year</code> is used in the new "Example" document <a href="https://github.com/dbsrgits/dbix-class/blob/master/lib/DBIx/Class/Manual/QuickStart.pod">https://github.com/dbsrgits/dbix-class/blob/master/lib/DBIx/Class/Manual/QuickStart.pod</a> . In fact it was raised on IRC whether we need <em>two</em> versions of a similar document, to which the original author said "meh" ;)</p>
<pre><code><ribasushi> daxim: food for thought - this seems like 90% of what you wrote (i.e. lots of doc-repetition) https://github.com/dbsrgits/dbix-class/blob/master/lib/DBIx/Class/Manual/Example.pod
<ribasushi> which *is* also just a hands-on practical tutorial
<ribasushi> and shows verbatim the scripts from examples/Schema
<ribasushi> daxim: did you ever considered we now have two quickstarts in a sense? any plan?
<daxim> IMO that pod is fine except for writing the schema manually
<daxim> merge if two pods are too many
<ribasushi> daxim: so it does not strike you as detrimental having 2 documents pertaining to the same thing?
<ribasushi> daxim: I am asking - I long lost the necessary pov to make such a judgement
<daxim> not much detriment
<ribasushi> daxim: aight then, keeping them as is for the time being
</code></pre>
<p>Perhaps a fix for this is more worthwhile if you think otherwise (two pods is confusing). Especially since it seems you <em>did</em> get confused as you removed year without consulting neither the Manuals nor the contents of examples/... </p>
<p>On the removal of the ResultSet class - I am on the fense. The fact that it isn't used now, doesn't mean it is not a good idea to create them <em>anyway</em>. In fact I was going to augment the example with base result/resultset clases since this is something that comes in handy 95% of the time, but usually there is too much code to change to make it work properly at the point you need them :(</p>
<p>In any case - closing this pull request without merging for the time being, as a large portion of it needs to be completely changed.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href='https://github.com/dbsrgits/dbix-class/pull/33#issuecomment-23846704'>view it on GitHub</a>.<img src='https://github.com/notifications/beacon/4W3BWTo7EIi_7vx28Xzl_k_jFMmCnnuFHaFj8TaPJ_TbTxd5XGX8r3ypiYv5BKXn.gif' height='1' width='1'></p>