Ah OK, thanks for the feedback. I'll check it out and see what makes sense,
<br>
then I'll ask for comments in #dbix-class.
<br>
On Jul 1, 2014 5:52 AM, "Peter Rabbitson" <notifications@github.com> wrote:
<br>
<br>
> Ok. While on the surface this looked like a trivial thing it actually
<br>
> turned out to be much more involved. These pieces were committed to
<br>
> current/for_cpan_index so far:
<br>
>
<br>
> - Some refactor of the docs 293a924
<br>
> <https://github.com/dbsrgits/dbix-class/commit/293a9242a> and
<br>
> downright purge of useless deps 77a6448
<br>
> <https://github.com/dbsrgits/dbix-class/commit/77a6448dc>
<br>
> - An easier-to-follow version of your datetime example a0a0da0
<br>
> <https://github.com/dbsrgits/dbix-class/commit/a0a0da0ae>
<br>
>
<br>
> The remaining piece is pushed to wip/moo_resultsets_docs, and has the
<br>
> following outstanding problem that needs attention: The Moose example has
<br>
> only BUILDARGS yet the Moo example has both BUILDARGS and FOREIGNBUILDARGS.
<br>
> Please investigate, see which one is right and resubmit changes to 15c43cf
<br>
> <https://github.com/dbsrgits/dbix-class/commit/15c43cfda> (the example
<br>
> code has to be flawless, as the cargocult of this will be high)
<br>
>
<br>
> As an aside - there was an issue brought up yesterday on IRC concerning
<br>
> Moose-based Result classes (not ResultSet classes). Perhaps a separate
<br>
> patch to document that inconsistency would also be of use:
<br>
>
<br>
> <corgifex> ribasushi: 1) is using Moose with DBIx::Class supported at all? 2) is MooseX::NonMoose + extends 'DBIx::Class::Core' the right way? 3) is 'lazy' a sensible workaround for DBIx::Class not calling the constructor? 4) is there a better way to do this?
<br>
> <ribasushi> corgifex: in this case it depends what you mean by "supported"
<br>
> <ribasushi> corgifex: the core DBIC result class has 2 separate constructors, which was a good idea at the time it was written, so if you expect constructor-based thingies to work, you will have to do some duct taping
<br>
> <ribasushi> corgifex: and as you already properly noted default non-lazy attributes do not work without constructor-based instantiation
<br>
> <ribasushi> corgifex: so it all depends on "how do you want things to interface" - it will be a tradeoff either way, and you need to decide where to make it
<br>
>
<br>
> Cheers and thanks again for looking into this
<br>
>
<br>
> —
<br>
> Reply to this email directly or view it on GitHub
<br>
> <https://github.com/dbsrgits/dbix-class/pull/49#issuecomment-47637403>.
<br>
>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/dbsrgits/dbix-class/pull/49#issuecomment-47650130">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/302594__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTgzNzMzMiwiZGF0YSI6eyJpZCI6MzU3ODkwMTV9fQ==--b3c52b5ff57d62de8b5dd38267939eef0f3d7339.gif" width="1" /></p>