<p>15:24 < mrf> ribasushi: pull request sent<br>
15:33 < ribasushi> mrf: several nits<br>
15:34 < ribasushi> I srtongly prefer the tests and implmentation in one commit - allows for proper bisecting<br>
15:34 < ribasushi> you can not assume DateTime is available - grep for "Optional::Dependencies" to see how to use it to properly skip the test when the thing isn't there <br>
15:35 < ribasushi> please move Date.pm into testlib, and give it a little less generic name<br>
15:36 < ribasushi> the implementation itself - you are subtly changing the if() semantics - previously if there was and inflate/deflate it would do stuff regardless of object type (even on db-stuff) - now this is no longer the case <br>
15:37 < ribasushi> (I am reading the diff under -w, makes this much more obvious)<br>
15:38 < ribasushi> mrf: other than that - excellent stuff, please see the above comments and resubmit the pr <br>
15:38 < ribasushi> mrf++<br>
15:38 < mrf> no probs will impliment and chuck back.<br><br>
15:38 < mrf> do you want me to squash it down into one commit. <br>
15:38 < mrf> ?<br>
15:38 < ribasushi> correct<br>
15:39 < ribasushi> mrf: the rationale is: bashing-into-submission history is not valuable enough to make the life of future bisecters/blamers difficult </p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/dbsrgits/dbix-class/pull/51#issuecomment-49445212">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/302594__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyMTMxNzA3OSwiZGF0YSI6eyJpZCI6MzczNzU1Nzd9fQ==--0f15d47e7d9ce27a54aebc3c45304994f0548f4c.gif" width="1" /></p>