<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Aug 26, 2014 at 2:45 PM, Peter Rabbitson <span dir="ltr"><<a href="mailto:notifications@github.com" target="_blank">notifications@github.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="">On 08/26/2014 02:10 PM, dbsrgits sync wrote:<br>
> > First of all many thanks for the time looking into this! I would <br>
> however<br>
> > like for you to look deeper into the issue. The current behavior seems<br>
> > wrong in itself, therefore the result is you adding a bandaid fixing<br>
> > something that should not have been there in the first place.<br>
> ><br>
> > The problem on the table is: we are connecting twice.<br>
> > The correct question isn't "why aren't we disconnecting", but rather <br>
> "why<br>
> > are we connecting twice?!"<br>
> ><br>
> > The solution would lie in examining the ::Versioned code and <br>
> determining<br>
> > whether any of the ->connect calls have anything special done to their<br></div>
> > connect attributes. If this is *not* the case (i.e. we always <br>
> connect to<br>
> > the same place *anyway*) - then clearly you are looking into a shared<br>
> > $dbh as can be seen in the *second* bullet point here:<div class=""><br>
> > <a href="https://metacpan.org/pod/DBIx::Class::Storage::DBI#connect_info" target="_blank">https://metacpan.org/pod/DBIx::Class::Storage::DBI#connect_info</a>. I will<br>
> > not be available for most of this week, please ask @frioux<br></div>
> > <<a href="https://github.com/frioux" target="_blank">https://github.com/frioux</a>> for help if you get stuck and/or have <br><div class="">
> trouble<br>
> > navigating my explanation.<br>
> ><br>
><br>
> @Peter: this sounds to me like a consequence of the connection race<br>
> condition we debugged and fixed some month ago where the wrong connection<br>
> got the session parameters set but the other one got used.<br>
><br></div>
Could you remind me which issue this was? .../Schema/Versioned.pm has <br>
not been touched since 2011, hence I am confused which issue/fix are you <br>
referring to.
</blockquote><div> </div><div>1eb87dd - Fix pesky on_connect_* race condition <br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="">
<div class="h5"><p style="font-size:small;color:rgb(102,102,102)">—<br>Reply to this email directly or <a href="https://github.com/dbsrgits/dbix-class/pull/57#issuecomment-53414571" target="_blank">view it on GitHub</a>.<img alt="" src="https://github.com/notifications/beacon/302594__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyNDY3NjMzNiwiZGF0YSI6eyJpZCI6NDA1Mzc4OTd9fQ==--f6942d6846329309872fd3088dcac5f62af02758.gif" height="1" width="1"></p>
</div></div><br>_______________________________________________<br>
DBIx-Class-Devel mailing list<br>
<a href="mailto:DBIx-Class-Devel@lists.scsys.co.uk">DBIx-Class-Devel@lists.scsys.co.uk</a><br>
<a href="http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class-devel" target="_blank">http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class-devel</a><br>
<br></blockquote></div><br></div></div>