On Wed, Oct 22, 2014 at 9:57 PM, Peter Rabbitson <notifications@github.com>
<br>
wrote:
<br>
<br>
> Hi @lasse-unity3d <https://github.com/lasse-unity3d>
<br>
>
<br>
> I had a chance to review your contribution after it was merged to the dev
<br>
> branch, and found some issues. Please read the detailed explanation here:
<br>
> f813551 <https://github.com/dbsrgits/dbix-class/commit/f8135512c>
<br>
>
<br>
Thanks for the explanation. I'm not nearly familiar enough with DBIC
<br>
internals yet to really grasp the implications of what you explained but
<br>
I'll try to read up on it.
<br>
<br>
Do you have concrete examples of breakage resulting from the patch? That
<br>
would be really helpful for me to understand the problem better...
<br>
<br>
> It would be great if you could spend some time to get the thing into
<br>
> shape, however given it has been a while it may be the case you no longer
<br>
> have the opportunity to work on this. Please let us know if this is the
<br>
> case, so someone else can pick it up and slog it to completion.
<br>
>
<br>
The issue is still relevant to me but since our porting to Oracle has been
<br>
postponed it's not my focus at the moment. We're in a bit of a crunch
<br>
currently but I'll try to get around to this again soon...
<br>
<br>
Vacation next week may or may not help with this... :-)
<br>
<br>
/L
<br>
<br>
> In any case: thanks for helping us make DBIC better ;)
<br>
>
<br>
> —
<br>
> Reply to this email directly or view it on GitHub
<br>
> <https://github.com/dbsrgits/dbix-class/pull/61#issuecomment-60145203>.
<br>
>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/dbsrgits/dbix-class/pull/61#issuecomment-60377705">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AASeAtp2KT6XYelZXNI9o7SmOYtkyJ6cks5nGjbygaJpZM4Cogo9.gif" width="1" /></p>
<script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"View this Pull Request on GitHub","action":{"@type":"ViewAction","url":"https://github.com/dbsrgits/dbix-class/pull/61#issuecomment-60377705","name":"View Pull Request"}}</script>