<p>Hi <a href="https://github.com/dinesh-it" class="user-mention">@dinesh-it</a>, <a href="https://github.com/timbunce" class="user-mention">@timbunce</a>,</p>
<p>Sorry for dropping the ball on this, github did not notify me (yet again) of activity post-close. This PR was dealing with two things - ANY and HSTORE, which I will address separately.</p>
<p>For <code>ANY</code> there is no need to add anything - it is covered by the current "generic operator" support:</p>
<pre><code>rabbit@Ahasver:~$ perl -MSQL::Abstract -MDevel::Dwarn -e 'Dwarn [ SQL::Abstract->new->where({ Group => { -any => { -ident => "Prepay" } } }) ]'
[
" WHERE ( Group ANY Prepay )"
]
rabbit@Ahasver:~$ perl -MSQL::Abstract -MDevel::Dwarn -e 'Dwarn [ SQL::Abstract->new->where({ Group => { -any => "Prepay" } }) ]'
[
" WHERE ( Group ANY ? )",
"Prepay"
]
</code></pre>
<p>For HSTORE implementing <code>-></code> alone and giving it an arbitrary name of <code>inhstore</code> seems a bit shortsighted to me from an API-design standpoint. I think any future work needs to strive to cover the entire <a href="http://www.postgresql.org/docs/9.4/static/hstore.html#HSTORE-OP-TABLE">gamut of currently supported operators</a> with an option open to future expansion.</p>
<p>Furthermore given how this is at this point firmly Postgres-only syntax (following their decision to repurpose <code>?</code>), its best implementation venue would be a subclass of <code>DBIx::Class::SQLMaker</code> settable post-connect, or something like that. </p>
<p>These are just superficial thoughts off-the-cuff. I have never used HSTORE personally, hence do not have much to add in terms of design advice.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/dbsrgits/sql-abstract/pull/2#issuecomment-69594752">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AASeAvIWhwOZ64LoHC-83_wYi3d0zh8lks5ng-pIgaJpZM4BwK_I.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/dbsrgits/sql-abstract/pull/2#issuecomment-69594752"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>