<p>10:42 < ether> cj: any suggestions for improving the docs?<br>
10:43 < cj> let me look at the columns section...<br>
10:44 < cj> I did see the "manual prefetch" section here and was curious how to do the non-manual version:<br>
10:44 < cj> <a href="http://search.cpan.org/%7Eribasushi/DBIx-Class-0.082810/lib/DBIx/Class/ResultSet.pm#columns">http://search.cpan.org/~ribasushi/DBIx-Class-0.082810/lib/DBIx/Class/ResultSet.pm#columns</a><br>
10:44 < cj> so maybe link the word prefetch to the #prefetch ?<br>
10:45 < cj> it would be even more clear if that block of code had a "produces the same thing as" with an example using prefetch =><br>
10:48 <a href="mailto:@ilmari">@ilmari</a> the prefetch documentation shows the equivalence<br>
10:48 <a href="mailto:@ilmari">@ilmari</a> I think just a link is good enough<br>
10:49 <a href="mailto:@ilmari">@ilmari</a> also, that example can't be done with prefetch, since it doesn't fetch all the columns of cds and tracks<br>
10:49 <a href="mailto:@ilmari">@ilmari</a> but linking the word "prefetch" in "manual prefetch" is a good idea<br>
10:50 <a href="mailto:@mst">@mst</a> cj: an example that <em>is</em> equivalent would be helpful, yes<br>
10:50 <a href="mailto:@mst">@mst</a> maybe you could give it a go?<br>
10:50 <a href="mailto:@ilmari">@ilmari</a> the equivalence is demonstrated in the prefetch docs already<br>
10:51 <a href="mailto:@mst">@mst</a> might make the manual prefetch clearer though<br>
10:51 <a href="mailto:@mst">@mst</a> show the prefetch, show what that expands to, show the cut down version<br>
10:52 < cj> mst: sure, got a git uri I can pull and munge?<br>
10:54 <a href="mailto:@ilmari">@ilmari</a> cj: <a href="https://github.com/dbsrgits/dbix-class">https://github.com/dbsrgits/dbix-class</a><br>
10:54 <a href="mailto:@ilmari">@ilmari</a> pull requests are accepted<br>
10:55 < cj> thanks<br>
11:06 < cj> is there a definition of the example cds and tracks tables so that I can flesh out the 'columns' vs 'prefetch' examples?<br>
11:06 < cj> I guess I would also need the artists table definition to make it accurate<br>
11:06 < cj> s/artists/artist/<br>
11:12 < ether> cj: have a look in t/lib in the repo<br>
11:13 < cj> thanks<br>
11:19 -!- mode/#dbix-class [+o castaway] by Bender<br>
11:23 < shadowpaste> "cj" at 217.168.150.38 pasted "columns / prefetch example" (52 lines) at <a href="http://paste.scsys.co.uk/468508">http://paste.scsys.co.uk/468508</a><br>
11:23 < cj> how's that look?<br>
11:23 < cj> I didn't run it. Is there a .t file where we exercise the example code?<br>
11:24 <a href="mailto:@ilmari">@ilmari</a> that's really very verbose and detracts from the point of columns, IMO<br>
11:24 <a href="mailto:@ilmari">@ilmari</a> pretty much exactly the same example (but with getting the column names from the result source, and joining to genres as well), is in L<br>
11:24 < cj> yeah, I was thinking the same sort of thing...<br>
11:26 < cj> mst: do you think that just adding the link to prefetch would be sufficient? I would have benefitted from knowing the concise version, but I may not be the target audience of that section...<br>
11:26 <a href="mailto:@ilmari">@ilmari</a> cj: L <em>has</em> the concise version, then the expanded one<br>
11:26 <a href="mailto:@mst">@mst</a> ... doh<br>
11:26 <a href="mailto:@mst">@mst</a> I should've checked for that<br>
11:26 <a href="mailto:@ilmari">@ilmari</a> s/</<\//<br>
11:27 <a href="mailto:@ilmari">@ilmari</a> 18:50 <a href="mailto:@ilmari">@ilmari</a> the equivalence is demonstrated in the prefetch docs already<br>
11:27 <a href="mailto:@ilmari">@ilmari</a> <em>cough</em><br>
11:27 <a href="mailto:@mst">@mst</a> there is a difference between 'the equivalence is demonstrated' and 'the exact example you describe is already there' :P<br>
11:32 < shadowpaste> "cj" at 217.168.150.38 pasted "fixing line wrap, linking prefetch, added appropriate whitespace after 'tracks'" (24 lines) at <a href="http://paste.scsys.co.uk/468509">http://paste.scsys.co.uk/468509</a><br>
11:32 < cj> better?<br>
11:34 * ilmari would prefer it with no rewrapping, <em>just</em> adding L</ > around prefetch<br>
11:34 <a href="mailto:@ilmari">@ilmari</a> for diff/blame tidyness, if nothing else<br>
11:37 < cj> roger</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/dbsrgits/dbix-class/pull/71'>https://github.com/dbsrgits/dbix-class/pull/71</a></p>
<h4>Commit Summary</h4>
<ul>
<li>linked "prefetch" in columns documentation; added whitespace after hash value</li>
</ul>
<h4>File Changes</h4>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/dbsrgits/dbix-class/pull/71/files#diff-0">lib/DBIx/Class/ResultSet.pm</a>
(4)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/dbsrgits/dbix-class/pull/71.patch'>https://github.com/dbsrgits/dbix-class/pull/71.patch</a></li>
<li><a href='https://github.com/dbsrgits/dbix-class/pull/71.diff'>https://github.com/dbsrgits/dbix-class/pull/71.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/dbsrgits/dbix-class/pull/71">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AASeAvcIsLTcLXw3xWERgYLggKZPgVYTks5nxLTAgaJpZM4DoQln.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/dbsrgits/dbix-class/pull/71"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>