<p>In <a href="https://github.com/dbsrgits/dbix-class/pull/88#discussion_r43757134">lib/SQL/Translator/Parser/DBIx/Class.pm</a>:</p>
<pre style='color:#555'>> @@ -149,13 +149,16 @@ sub parse {
>
> $table->primary_key(@primary) if @primary;
>
> - my %unique_constraints = $source->unique_constraints;
> - foreach my $uniq (sort keys %unique_constraints) {
> - if (!$source->_compare_relationship_keys($unique_constraints{$uniq}, \@primary)) {
> + my $unique_constraints = $source->unique_constraints_info;
> + foreach my $uniq (sort keys %$unique_constraints) {
> + my $cons = $unique_constraints->{$uniq};
</pre>
<p>Don't add extremely short-lived intermediate variables like that, it makes code harder to reason about, as in <em>why did he save it only to use it a couple times in this function, what am I missing</em></p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>Reply to this email directly or <a href="https://github.com/dbsrgits/dbix-class/pull/88/files#r43757134">view it on GitHub</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AASeAhg6PZOnLVsEuY_3iQlWQaZ8E5Kmks5pCMPCgaJpZM4Ga5rQ.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/dbsrgits/dbix-class/pull/88/files#r43757134"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>