<p><b>@ilmari</b> requested changes on this pull request.</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/sql-translator/pull/87#discussion_r109373942">lib/SQL/Translator/Parser/MySQL.pm</a>:</p>
<pre style='color:#555'>> @@ -326,7 +326,7 @@ create : CREATE PROCEDURE NAME not_delimiter "$delimiter"
PROCEDURE : /procedure/i
| /function/i
-create : CREATE or_replace(?) create_view_option(s?) /view/i NAME /as/i view_select_statement "$delimiter"
+create : CREATE or_replace(?) create_view_option(s?) /view/i NAME parens_field_list(?) /as/i view_select_statement "$delimiter"
</pre>
<p>An explicit field list overrides the names derived from the <code>SELECT</code> column list, so the field list needs to be saved here and stored in the <code>fields</code> attribute of the <code>SQL::Translator::Schema::View</code> object.</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/sql-translator/pull/87#discussion_r109374175">t/02mysql-parser.t</a>:</p>
<pre style='color:#555'>> @@ -502,6 +502,19 @@ BEGIN {
is( join(',', $t2c2->reference_fields), 'id', 'To field "id"' );
}
+# Tests for CREATE VIEW statements that contain a column list
+# after the view name
+{
+ my $tr = SQL::Translator->new();
+ my $data = parse($tr,
+ q[
+ CREATE
+ VIEW view_foo (id, name) AS
+ SELECT id, name FROM thing;
+ ]
+ ) or die $tr->error;
</pre>
<p>Please also test that the view is in fact correctly parsed and that the column names after the view name take precedence over the ones in the <code>SELECT</code> list.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/dbsrgits/sql-translator/pull/87#pullrequestreview-30470507">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AASeAj1PWEnaPMaGGsVdX8EqrijvJxz8ks5rsMPpgaJpZM4Mw61A">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AASeAupM8IiTTcWnsuoSg_c-TBzrIg4sks5rsMPpgaJpZM4Mw61A.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/dbsrgits/sql-translator/pull/87#pullrequestreview-30470507"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/dbsrgits/sql-translator","title":"dbsrgits/sql-translator","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/dbsrgits/sql-translator"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ilmari requested changes on #87"}],"action":{"name":"View Pull Request","url":"https://github.com/dbsrgits/sql-translator/pull/87#pullrequestreview-30470507"}}}</script>