<h2>Why terrible?</h2>
<ul>
<li>It outputs syntax that will result in an error when executed.<br>
<code>ALTER TABLE tablename ALTER colname TYPE serial;</code></li>
<li>When parsing from DBI, unexpected types are returned</li>
<li>Similarly, unexpected sizes are returned</li>
<li>There is no type match for time</li>
</ul>
<h2>What I did?</h2>
<ul>
<li>I rewrote SQL to solve the above problem.</li>
<li>Added a dedicated parser statement for <code>smallserial</code>.</li>
<li>When type like serial, we modified it to use <code>CREATE SEQUENCE</code> instead of <code>ALTER</code>.</li>
</ul>
<p>Best regard <g-emoji alias="+1" fallback-src="https://assets-cdn.github.com/images/icons/emoji/unicode/1f44d.png" ios-version="6.0">👍</g-emoji></p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>&nbsp;&nbsp;<a href='https://github.com/dbsrgits/sql-translator/pull/91'>https://github.com/dbsrgits/sql-translator/pull/91</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>Fixed issue `ERROR:  type &quot;serial&quot; does not exist`</li>
  <li>Modified tests for postgres</li>
  <li>Modified producer to generate time or timestamp</li>
  <li>Fixed to parse from DBI using PostgreSQL</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/dbsrgits/sql-translator/pull/91/files#diff-0">lib/SQL/Translator/Parser/DBI/PostgreSQL.pm</a>
    (26)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/dbsrgits/sql-translator/pull/91/files#diff-1">lib/SQL/Translator/Parser/PostgreSQL.pm</a>
    (9)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/dbsrgits/sql-translator/pull/91/files#diff-2">lib/SQL/Translator/Producer/PostgreSQL.pm</a>
    (87)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/dbsrgits/sql-translator/pull/91/files#diff-3">t/30sqlt-new-diff-pgsql.t</a>
    (16)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/dbsrgits/sql-translator/pull/91/files#diff-4">t/47postgres-producer.t</a>
    (4)
  </li>
  <li>
    <strong>M</strong>
    <a href="https://github.com/dbsrgits/sql-translator/pull/91/files#diff-5">t/66-postgres-dbi-parser.t</a>
    (5)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/dbsrgits/sql-translator/pull/91.patch'>https://github.com/dbsrgits/sql-translator/pull/91.patch</a></li>
  <li><a href='https://github.com/dbsrgits/sql-translator/pull/91.diff'>https://github.com/dbsrgits/sql-translator/pull/91.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/dbsrgits/sql-translator/pull/91">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AASeAm5h_ZLeqMMcRLK8zdEfUYTDJv7Jks5r7FkxgaJpZM4NfVxn">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AASeAnCWxfSjO5h41fKKu8hjIgMvRriUks5r7FkxgaJpZM4NfVxn.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/dbsrgits/sql-translator/pull/91"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/dbsrgits/sql-translator","title":"dbsrgits/sql-translator","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/dbsrgits/sql-translator"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Fixed a terrible diff issue case of PostgreSQL (#91)"}],"action":{"name":"View Pull Request","url":"https://github.com/dbsrgits/sql-translator/pull/91"}}}</script>