<p>In production, we found that the stable CPAN release of the PostgreSQL<br>
producer did not quote identifiers in diffs.  We diagnosed the problem<br>
and wrote a fix, only to see it was fixed in master.  Oh well, we<br>
learned some more about SQLT!</p>
<p>I had adapted my test to run against a few producers, and found that<br>
SQLite didn't work, even in master.  The first cause seemed like the<br>
same bug as I found in PostgreSQL:  add_field did not pass its options<br>
to the generator to inform its quoting.  I have fixed that in the patch,<br>
but it still fails.</p>
<p>The fundamental problem appears to be the weird (to me) <code>$NO_QUOTES</code><br>
behavior.  That variable is set in <code>-&gt;produce</code>, a method that <em>does not<br>
seem to be called</em> in the execution of the test program.  At that point,<br>
I gave up for now, but I wanted to file this issue.</p>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>&nbsp;&nbsp;<a href='https://github.com/dbsrgits/sql-translator/pull/96'>https://github.com/dbsrgits/sql-translator/pull/96</a></p>

<h4>Commit Summary</h4>
<ul>
  <li>WIP: test quoting of identifiers in diff</li>
</ul>

<h4>File Changes</h4>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/dbsrgits/sql-translator/pull/96/files#diff-0">lib/SQL/Translator/Producer/SQLite.pm</a>
    (5)
  </li>
  <li>
    <strong>A</strong>
    <a href="https://github.com/dbsrgits/sql-translator/pull/96/files#diff-1">t/XX-quote-diff.t</a>
    (63)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/dbsrgits/sql-translator/pull/96.patch'>https://github.com/dbsrgits/sql-translator/pull/96.patch</a></li>
  <li><a href='https://github.com/dbsrgits/sql-translator/pull/96.diff'>https://github.com/dbsrgits/sql-translator/pull/96.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/dbsrgits/sql-translator/pull/96">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AASeAvBYF-prTTY_0pEYmNHLzbeCa7oHks5slELUgaJpZM4PhWZe">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AASeAg0XX4M3Wmm9ygyAmhL0Vmi8M01jks5slELUgaJpZM4PhWZe.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/dbsrgits/sql-translator/pull/96"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/dbsrgits/sql-translator","title":"dbsrgits/sql-translator","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/dbsrgits/sql-translator"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"WIP: quoting of identifiers in diff, SQLite and test (#96)"}],"action":{"name":"View Pull Request","url":"https://github.com/dbsrgits/sql-translator/pull/96"}}}</script>