<p><b>@ilmari</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/dbsrgits/sql-abstract/pull/13#discussion_r164300398">lib/SQL/Abstract.pm</a>:</p>
<pre style='color:#555'>&gt; @@ -466,15 +466,21 @@ sub select {
 
   my($where_sql, @bind) = $self-&gt;where($where, $order);
 
-  my $f = (ref $fields eq &#39;ARRAY&#39;) ? join &#39;, &#39;, map { $self-&gt;_quote($_) } @$fields
-                                   : $fields;
-  my $sql = join(&#39; &#39;, $self-&gt;_sqlcase(&#39;select&#39;), $f,
+  my ($fields_sql, @fields_bind) = $self-&gt;_select_field_values($fields);
+  push @bind, @fields_bind;
</pre>
<p>Because <code>$fields_sql</code> comes before <code>$where_sql</code>, <code>@fields_bind</code> need to come before the bind values returned by <code>-&gt;where()</code>. I'd suggest moving the whole fields part before the where part, to make this clearer.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/dbsrgits/sql-abstract/pull/13#pullrequestreview-92054127">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AASeAqjkOM0cDG8E1s3wK0RFLtNdYtcfks5tPH-6gaJpZM4Rvqe1">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AASeArhyBmLtiuyG7FdAoMgIR6ZvHVYzks5tPH-6gaJpZM4Rvqe1.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
  <link itemprop="url" href="https://github.com/dbsrgits/sql-abstract/pull/13#pullrequestreview-92054127"></link>
  <meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/dbsrgits/sql-abstract","title":"dbsrgits/sql-abstract","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/dbsrgits/sql-abstract"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ilmari requested changes on #13"}],"action":{"name":"View Pull Request","url":"https://github.com/dbsrgits/sql-abstract/pull/13#pullrequestreview-92054127"}}}</script>