<p><b>@haarg</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#discussion_r164298052">Makefile.PL</a>:</p>
<pre style='color:#555'>> -requires 'String::CamelCase' => '0.02';
-requires 'Sub::Util' => '1.40';
-requires 'Try::Tiny' => 0;
-
-# core, but specific versions not available on older perls
-requires 'Digest::MD5' => '2.36';
-requires 'Exporter' => '5.63';
+sub _move_to {
+ my ($hash, $fromkey, $tokey) = @_;
+ $hash->{$tokey} = {
+ %{ $hash->{$tokey} || {} },
+ %{ delete($hash->{$fromkey}) || {} },
+ };
+}
+delete $eumm_args{META_MERGE} if $eumm_version < 6.45_01;
+_move_to(\%eumm_args, 'CONFIGURE_REQUIRES', 'PREREQ_PM')
</pre>
<p>This doesn't accomplish much. It's too late for configure prereqs to be satisfied here. Deleting <code>CONFIGURE_REQUIRES</code> to silence the warning is the only useful thing that can be done.</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#discussion_r164298079">Makefile.PL</a>:</p>
<pre style='color:#555'>> -requires 'Exporter' => '5.63';
+sub _move_to {
+ my ($hash, $fromkey, $tokey) = @_;
+ $hash->{$tokey} = {
+ %{ $hash->{$tokey} || {} },
+ %{ delete($hash->{$fromkey}) || {} },
+ };
+}
+delete $eumm_args{META_MERGE} if $eumm_version < 6.45_01;
+_move_to(\%eumm_args, 'CONFIGURE_REQUIRES', 'PREREQ_PM')
+ if $eumm_version < 6.51_03;
+_move_to(\%eumm_args, 'BUILD_REQUIRES', 'PREREQ_PM')
+ if $eumm_version < 6.55_01;
+$eumm_args{NO_MYMETA} = 1
+ if $eumm_version >= 6.57_02 and $eumm_version < 6.57_07;
+_move_to(\%eumm_args, 'TEST_REQUIRES', 'PREREQ_PM')
</pre>
<p>This should move the prereqs to <code>BUILD_REQUIRES</code> and be moved before <code>BUILD_REQUIRES</code> gets conditionally moved to <code>PREREQ_PM</code>.</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#discussion_r164298173">maint/Makefile.PL.include</a>:</p>
<pre style='color:#555'>> +use lib 'Distar/lib';
+use Distar 0.001;
+
+author 'Caelum: Rafael Kitover <rkitover@cpan.org>';
+
+manifest_include 't/backcompat/0.04006/lib' => qr/.*\.pm$/;
+manifest_include 't/bin' => qr/.*/;
+
+use FindBin;
+use lib "$FindBin::Bin/lib";
+require DBIx::Class::Schema::Loader::Optional::Dependencies;
+my $optdeps = 'DBIx::Class::Schema::Loader::Optional::Dependencies';
+my @req_groups = keys %{ $optdeps->req_group_list };
+my @rdbms_groups = grep { /rdbms/ } @req_groups;
+my @other_groups = grep { !/rdbms/ } @req_groups;
+our (%dev_requires, %runtime_suggests);
</pre>
<p>I think this is a confusing way to communicate with the rest of the <code>Makefile.PL</code>.</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#discussion_r164298286">Makefile.PL</a>:</p>
<pre style='color:#555'>> @@ -2,67 +2,103 @@ use warnings;
use strict;
use 5.008001;
-BEGIN { unshift @INC, '.' unless $INC[-1] eq '.'; }
-use inc::Module::Install 1.00;
-
-use Getopt::Long();
-
-my $getopt = Getopt::Long::Parser->new(
- config => [qw/gnu_getopt bundling_override no_ignore_case pass_through/]
+use ExtUtils::MakeMaker;
+our (%dev_requires, %runtime_suggests);
+(do './maint/Makefile.PL.include' or die $@) unless -f 'META.yml';
+
+my $eumm_version = eval $ExtUtils::MakeMaker::VERSION;
+my %eumm_args = (
+ NAME => 'DBIx::Class::Schema::Loader',
+ AUTHOR => 'Caelum: Rafael Kitover <rkitover@cpan.org>',
</pre>
<p>Redundant with Distar's author handing.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#pullrequestreview-92051683">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AASeAuwpjAYJA_EyCLGSHESVWlYUJBI6ks5tPG6GgaJpZM4Rvk8o">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AASeAh7tnJYV0VmRk0vEx_n-wzurt7foks5tPG6GgaJpZM4Rvk8o.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#pullrequestreview-92051683"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/dbsrgits/dbix-class-schema-loader","title":"dbsrgits/dbix-class-schema-loader","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/dbsrgits/dbix-class-schema-loader"}},"updates":{"snippets":[{"icon":"PERSON","message":"@haarg commented on #17"}],"action":{"name":"View Pull Request","url":"https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#pullrequestreview-92051683"}}}</script>