<p><b>@ilmari</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#discussion_r164423616">Makefile.PL</a>:</p>
<pre style='color:#555'>> + EXE_FILES => [ qw(script/dbicdump) ],
+ META_MERGE => {
+ "meta-spec" => { version => 2 },
+ dynamic_config => 0,
+ resources => {
+ repository => {
+ type => 'git',
+ url => 'git@github.com/dbsrgits/dbix-class-schema-loader.git',
+ web => 'https://github.com/dbsrgits/dbix-class-schema-loader',
+ },
+ x_IRC => 'irc://irc.perl.org/#dbix-class',
+ license => [ 'http://dev.perl.org/licenses/' ],
+ x_MailingList => 'http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class',
+ },
+ no_index => {
+ directory => [qw(maint xt)],
</pre>
<p>PAUSE already doesn't index anything in <code>inc</code>, <code>xt</code>, and <code>t</code>, so I think we should either list <code>t</code> explicitly here for completeness, or only explicitly list <code>maint</code> for conciseness.</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#discussion_r164424370">maint/Makefile.PL.include</a>:</p>
<pre style='color:#555'>> +
+author 'Caelum: Rafael Kitover <rkitover@cpan.org>';
+
+manifest_include 't/backcompat/0.04006/lib' => qr/.*\.pm$/;
+manifest_include 't/bin' => qr/.*/;
+
+use FindBin;
+use lib "$FindBin::Bin/lib";
+require DBIx::Class::Schema::Loader::Optional::Dependencies;
+my $optdeps = 'DBIx::Class::Schema::Loader::Optional::Dependencies';
+my @req_groups = keys %{ $optdeps->req_group_list };
+my @rdbms_groups = grep { /rdbms/ } @req_groups;
+my @other_groups = grep { !/rdbms/ } @req_groups;
+our (%dev_requires, %runtime_suggests);
+%dev_requires = %{ $optdeps->modreq_list_for(\@other_groups) };
+%runtime_suggests = %{ $optdeps->modreq_list_for(\@rdbms_groups) };
</pre>
<p>We don't currently suggest any of the RDBMS-specific modules, and I'd like to keep actual behaviour changes to a minimum in this PR. If we want to further tweak the deps, that should be a separate discussion.</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#discussion_r164425402">maint/Makefile.PL.include</a>:</p>
<pre style='color:#555'>> +use lib 'Distar/lib';
+use Distar 0.001;
+
+author 'Caelum: Rafael Kitover <rkitover@cpan.org>';
+
+manifest_include 't/backcompat/0.04006/lib' => qr/.*\.pm$/;
+manifest_include 't/bin' => qr/.*/;
+
+use FindBin;
+use lib "$FindBin::Bin/lib";
+require DBIx::Class::Schema::Loader::Optional::Dependencies;
+my $optdeps = 'DBIx::Class::Schema::Loader::Optional::Dependencies';
+my @req_groups = keys %{ $optdeps->req_group_list };
+my @rdbms_groups = grep { /rdbms/ } @req_groups;
+my @other_groups = grep { !/rdbms/ } @req_groups;
+our (%dev_requires, %runtime_suggests);
</pre>
<p>One option would be to return a hash from the script and do something like</p>
<pre><code>my %dev_requires = -f 'META.yml' ? () : (do './maint/Makefile.PL.include' or die $@);
</code></pre>
<p>in <code>Makefile.PL</code>, but I'm not entirely sure I like that either.</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#discussion_r164425897">Makefile.PL</a>:</p>
<pre style='color:#555'>> + },
+ realclean => {
+ FILES => 'lib/DBIx/Class/Schema/Loader/Optional/Dependencies.pod'
+ },
+ EXE_FILES => [ qw(script/dbicdump) ],
+ META_MERGE => {
+ "meta-spec" => { version => 2 },
+ dynamic_config => 0,
+ resources => {
+ repository => {
+ type => 'git',
+ url => 'git@github.com/dbsrgits/dbix-class-schema-loader.git',
+ web => 'https://github.com/dbsrgits/dbix-class-schema-loader',
+ },
+ x_IRC => 'irc://irc.perl.org/#dbix-class',
+ license => [ 'http://dev.perl.org/licenses/' ],
</pre>
<p>Doesn't EUMM automatically generate this from the <code>LICENSE => 'perl'</code> above?</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#discussion_r164426541">Makefile.PL</a>:</p>
<pre style='color:#555'>> + 'ExtUtils::MakeMaker' => '0',
+ },
+ TEST_REQUIRES => {
+ 'DBD::SQLite' => '1.29',
+ 'Test::Exception' => '0.31',
+ 'Test::More' => '0.94',
+ 'Test::Warn' => '0.21',
+ 'Test::Deep' => '0.107',
+ 'Test::Differences' => '0.60',
+ # temporary, needs to be thrown out
+ 'DBIx::Class::IntrospectableM2M' => 0,
+ # core, but specific versions not available on older perls
+ 'File::Temp' => '0.16',
+ 'File::Path' => '2.07',
+ },
+ test => {TESTS => 't/*.t t/*/*.t'},
</pre>
<p>This needs to include <code>t/*/*/*.t</code>, since the backcompat tests are two directories deep. There aren't actually any files matching <code>t/*/*.t</code>, but I guess it doesn't hurt to include it for future-proofing.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#pullrequestreview-92192020">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AASeAkr9XaleMLVvTflIvJ90zws5jf4Cks5tPcU-gaJpZM4Rvk8o">mute the thread</a>.<img alt="" height="1" src="https://github.com/notifications/beacon/AASeAtWwvXPVtGx00tnnauHNcLYb4noCks5tPcU-gaJpZM4Rvk8o.gif" width="1" /></p>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#pullrequestreview-92192020"></link>
<meta itemprop="name" content="View Pull Request"></meta>
</div>
<meta itemprop="description" content="View this Pull Request on GitHub"></meta>
</div>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/dbsrgits/dbix-class-schema-loader","title":"dbsrgits/dbix-class-schema-loader","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/dbsrgits/dbix-class-schema-loader"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ilmari commented on #17"}],"action":{"name":"View Pull Request","url":"https://github.com/dbsrgits/dbix-class-schema-loader/pull/17#pullrequestreview-92192020"}}}</script>