<p>The more important issue here is that it is not clear cut what does <em>handle the "extra" key</em> actually mean. Currently if one wants to <strong>rewrite</strong> the <code>extra</code> contents, they can do it with a <code>+foo</code>. After your patch - they will no longer be able to.</p>
<p>As your patch came without an extensive test case, it is difficult for me to figure out what your use case is. I <strong>suspect</strong> that you simply find the behavior you are proposing a better default, and could do what you want today instead as:</p>
<pre><code>__PACKAGE__-&gt;add_column(
  '+foo' =&gt; { ... extra =&gt; {
    %{ __PACKAGE__-&gt;column_info("foo")-&gt;{extra} || {} }
    &lt; extra stuff above or below this line depending whether you want override or default else &gt;
  } }
);
</code></pre>
<p>I am in general very disinclined changing established behavioral defaults. Please explain in more detail why this case warrants an exemption.</p>
<p>P.S. I am leaving on a week-long trip: might not read/respond for a while</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/Perl5/DBIx-Class/pull/128#issuecomment-409095082">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AASeAvvcXTH15nNkYS3lFnksLUyvN01iks5uL-RIgaJpZM4VnZrN">mute the thread</a>.<img src="https://github.com/notifications/beacon/AASeAnP72rgpZ0EoN7mlNS9X6OlLfV1Iks5uL-RIgaJpZM4VnZrN.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Perl5/DBIx-Class","title":"Perl5/DBIx-Class","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/Perl5/DBIx-Class"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ribasushi in #128: The more important issue here is that it is not clear cut what does *handle the \"extra\" key* actually mean. Currently if one wants to **rewrite** the `extra` contents, they can do it with a `+foo`. After your patch - they will no longer be able to.\r\n\r\nAs your patch came without an extensive test case, it is difficult for me to figure out what your use case is. I **suspect** that you simply find the behavior you are proposing a better default, and could do what you want today instead as:\r\n```\r\n__PACKAGE__-\u003eadd_column(\r\n  '+foo' =\u003e { ... extra =\u003e {\r\n    %{ __PACKAGE__-\u003ecolumn_info(\"foo\")-\u003e{extra} || {} }\r\n    \u003c extra stuff above or below this line depending whether you want override or default else \u003e\r\n  } }\r\n);\r\n```\r\n\r\nI am in general very disinclined changing established behavioral defaults. Please explain in more detail why this case warrants an exemption.\r\n\r\nP.S. I am leaving on a week-long trip: might not read/respond for a while"}],"action":{"name":"View Pull Request","url":"https://github.com/Perl5/DBIx-Class/pull/128#issuecomment-409095082"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/Perl5/DBIx-Class/pull/128#issuecomment-409095082",
"url": "https://github.com/Perl5/DBIx-Class/pull/128#issuecomment-409095082",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [Perl5/DBIx-Class] Use deep merge for column info when adding columns (#128)",
"sections": [
{
"text": "",
"activityTitle": "**Peter Rabbitson**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ribasushi",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"Perl5/DBIx-Class\",\n\"issueId\": 128,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"Perl5/DBIx-Class\",\n\"pullRequestId\": 128\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/Perl5/DBIx-Class/pull/128#issuecomment-409095082"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 362650317\n}"
}
],
"themeColor": "26292E"
}
]</script>