<p><b>@dboehmer</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/Perl5/DBIx-Class/pull/129#discussion_r235614578">lib/DBIx/Class/ResultSource.pm</a>:</p>
<pre style='color:#555'>&gt; @@ -1531,7 +1531,7 @@ sub reverse_relationship_info {
 sub __strip_relcond {
   +{
     map
-      { map { /^ (?:foreign|self) \. (\w+) $/x } ($_, $_[1]{$_}) }
+      { map { /^ (?:foreign|self) \. (.+) $/x } ($_, $_[1]{$_}) }
</pre>
<p>While this regex is not DBMS-specific all new allowed characters (all of <code>\W</code>) seem to be relevant for MS-SQL only. So I suggest to still limit the allowed characters to those allowed in MS-SQL.</p>
<p>I took a quick look at <a href="https://docs.microsoft.com/en-us/sql/odbc/microsoft/column-name-limitations?view=sql-server-2017" rel="nofollow">https://docs.microsoft.com/en-us/sql/odbc/microsoft/column-name-limitations?view=sql-server-2017</a></p>
<ul>
<li><code>`</code> is not allowed</li>
<li><code>|</code> is not allowed</li>
</ul>
<p>So I suggest <code>[^`|]+</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/Perl5/DBIx-Class/pull/129#pullrequestreview-177519270">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AASeAmVvMBbpqXgVbp9aSVIB2jsBYNFIks5uxkaSgaJpZM4XZ4rx">mute the thread</a>.<img src="https://github.com/notifications/beacon/AASeArXYJGKscIOpWIqLrdWINwmFpqSOks5uxkaSgaJpZM4XZ4rx.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Perl5/DBIx-Class","title":"Perl5/DBIx-Class","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/Perl5/DBIx-Class"}},"updates":{"snippets":[{"icon":"PERSON","message":"@dboehmer commented on #129"}],"action":{"name":"View Pull Request","url":"https://github.com/Perl5/DBIx-Class/pull/129#pullrequestreview-177519270"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/Perl5/DBIx-Class/pull/129#pullrequestreview-177519270",
"url": "https://github.com/Perl5/DBIx-Class/pull/129#pullrequestreview-177519270",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "@dboehmer commented on 129",
"sections": [
{
"text": "",
"activityTitle": "**Daniel Böhmer**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@dboehmer",
"facts": [

]
}
],
"potentialAction": [
{
"targets": [
{
"os": "default",
"uri": "https://github.com/Perl5/DBIx-Class/pull/129#pullrequestreview-177519270"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 392661745\n}"
}
],
"themeColor": "26292E"
}
]</script>