<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=97892" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/toddr">@toddr</a> <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="13784776" data-permission-text="Issue title is private" data-url="https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58" data-hovercard-type="issue" data-hovercard-url="/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58/hovercard?comment_id=17455661&amp;comment_type=issue_comment" href="https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58#issuecomment-17455661">Perl-Toolchain-Gang/ExtUtils-MakeMaker#58 (comment)</a></p>
<p>Also please read that same discussion starting from her: <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="13784776" data-permission-text="Issue title is private" data-url="https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58" data-hovercard-type="issue" data-hovercard-url="/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58/hovercard?comment_id=310535412&amp;comment_type=issue_comment" href="https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58#issuecomment-310535412">Perl-Toolchain-Gang/ExtUtils-MakeMaker#58 (comment)</a></p>
<p>This ( <code>EU::MM</code> ) would be the correct place to apply this fix, with a way for users being able to disable ( if default ) or enable ( if not ) this rewriting.</p>
<p>If this is <strong>really</strong> a showstopper, I would be amenable to accept a patch to <code>Makefile.PL</code> in the spirit of <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="13784776" data-permission-text="Issue title is private" data-url="https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58" data-hovercard-type="issue" data-hovercard-url="/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58/hovercard?comment_id=384070066&amp;comment_type=issue_comment" href="https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58#issuecomment-384070066">Perl-Toolchain-Gang/ExtUtils-MakeMaker#58 (comment)</a> ( unless the EU::MM default behavior changes, this patch will have to be strictly opt-in with an envvar, preferably matching the one proposed for EU::MM )</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/Perl5/DBIx-Class/pull/130#issuecomment-442351464">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AASeAvwCfIobR2WhxwD5RupCNvIPLD7eks5uzkADgaJpZM4Y2R-F">mute the thread</a>.<img src="https://github.com/notifications/beacon/AASeAsv40H9V_Jytv2jo5IysTlchQhbeks5uzkADgaJpZM4Y2R-F.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Perl5/DBIx-Class","title":"Perl5/DBIx-Class","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/Perl5/DBIx-Class"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ribasushi in #130: @toddr https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58#issuecomment-17455661\r\n\r\nAlso please read that same discussion starting from her: https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58#issuecomment-310535412\r\n\r\nThis ( `EU::MM` ) would be the correct place to apply this fix, with a way for users being able to disable ( if default ) or enable ( if not ) this rewriting.\r\n\r\nIf this is **really** a showstopper, I would be amenable to accept a patch to `Makefile.PL` in the spirit of https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker/issues/58#issuecomment-384070066 ( unless the EU::MM default behavior changes, this patch will have to be strictly opt-in with an envvar, preferably matching the one proposed for EU::MM )"}],"action":{"name":"View Pull Request","url":"https://github.com/Perl5/DBIx-Class/pull/130#issuecomment-442351464"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/Perl5/DBIx-Class/pull/130#issuecomment-442351464",
"url": "https://github.com/Perl5/DBIx-Class/pull/130#issuecomment-442351464",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [Perl5/DBIx-Class] Patch dbicadmin support the #! Makefile.PL was invoked with (#130)",
"sections": [
{
"text": "",
"activityTitle": "**Peter Rabbitson**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ribasushi",
"facts": [

]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"Perl5/DBIx-Class\",\n\"issueId\": 130,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"Perl5/DBIx-Class\",\n\"pullRequestId\": 130\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/Perl5/DBIx-Class/pull/130#issuecomment-442351464"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 416882565\n}"
}
],
"themeColor": "26292E"
}
]</script>