<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=97892" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/toddr">@toddr</a> this patch can't be accepted. It assumes that every user wants this rewrite to take place unconditionally, removing access to the current <code>local::lib</code>-friendly behavior from users relying on it.</p>
<p>IIRC to get what you want the user needs to set the proper EU::MM environment variable ( I don't recall what was settled on ) at install time, so that the install process does the proper rewriting.</p>
<p>I will leave this PR open until we clarify whether the above works for you and/or whether I missed something.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/Perl5/DBIx-Class/pull/130#issuecomment-442218130">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AASeAlrJwR39RHcEwxeIrL_OxVjSSP5mks5uzapPgaJpZM4Y2R-F">mute the thread</a>.<img src="https://github.com/notifications/beacon/AASeAokYMVdVcsnfMet6Te0dDBDGUPz8ks5uzapPgaJpZM4Y2R-F.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Perl5/DBIx-Class","title":"Perl5/DBIx-Class","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/Perl5/DBIx-Class"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ribasushi in #130: @toddr this patch can't be accepted. It assumes that every user wants this rewrite to take place unconditionally, removing access to the current `local::lib`-friendly behavior from users relying on it.\r\n\r\nIIRC to get what you want the user needs to set the proper EU::MM environment variable ( I don't recall what was settled on ) at install time, so that the install process does the proper rewriting.\r\n\r\nI will leave this PR open until we clarify whether the above works for you and/or whether I missed something."}],"action":{"name":"View Pull Request","url":"https://github.com/Perl5/DBIx-Class/pull/130#issuecomment-442218130"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/Perl5/DBIx-Class/pull/130#issuecomment-442218130",
"url": "https://github.com/Perl5/DBIx-Class/pull/130#issuecomment-442218130",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
},
{
"@type": "MessageCard",
"@context": "http://schema.org/extensions",
"hideOriginalBody": "false",
"originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB",
"title": "Re: [Perl5/DBIx-Class] Patch dbicadmin support the #! Makefile.PL was invoked with (#130)",
"sections": [
{
"text": "",
"activityTitle": "**Peter Rabbitson**",
"activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png",
"activitySubtitle": "@ribasushi",
"facts": [
]
}
],
"potentialAction": [
{
"name": "Add a comment",
"@type": "ActionCard",
"inputs": [
{
"isMultiLine": true,
"@type": "TextInput",
"id": "IssueComment",
"isRequired": false
}
],
"actions": [
{
"name": "Comment",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"Perl5/DBIx-Class\",\n\"issueId\": 130,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}"
}
]
},
{
"name": "Close pull request",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"PullRequestClose\",\n\"repositoryFullName\": \"Perl5/DBIx-Class\",\n\"pullRequestId\": 130\n}"
},
{
"targets": [
{
"os": "default",
"uri": "https://github.com/Perl5/DBIx-Class/pull/130#issuecomment-442218130"
}
],
"@type": "OpenUri",
"name": "View on GitHub"
},
{
"name": "Unsubscribe",
"@type": "HttpPOST",
"target": "https://api.github.com",
"body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 416882565\n}"
}
],
"themeColor": "26292E"
}
]</script>