<blockquote>
<p>Folks, the issue here isn't how to fix the code</p>
</blockquote>
<p>I should have clarified this further: the reason this particular PR was left open was detailed earlier in <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="369642735" data-permission-text="Issue title is private" data-url="https://github.com/Perl5/DBIx-Class/issues/129" data-hovercard-type="pull_request" data-hovercard-url="/Perl5/DBIx-Class/pull/129/hovercard?comment_id=440952318&amp;comment_type=issue_comment" href="https://github.com/Perl5/DBIx-Class/pull/129#issuecomment-440952318">#129 (comment)</a> :</p>
<blockquote>
<p>...However - there are a few other places that need a similar update, and as the PR came with no tests of any sort - the spots got missed :(</p>
</blockquote>
<p>Even though there is a different implementation to be released soon which solves the problem by accident, it would still be good to have a test for this. So if time permits <strong>please</strong> contribute a test to go with the minimal changeset by <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=12764604" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/yewtc">@yewtc</a> above.</p>
<p>Thanks!</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/Perl5/DBIx-Class/pull/129#issuecomment-451107759">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AASeAmGtBHid5Q9arzC9GsVvDJd2nuG9ks5u_d26gaJpZM4XZ4rx">mute the thread</a>.<img src="https://github.com/notifications/beacon/AASeAtLchV1eGV0YvVNa9VtxaANqUUJRks5u_d26gaJpZM4XZ4rx.gif" height="1" width="1" alt="" /></p>
<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/Perl5/DBIx-Class","title":"Perl5/DBIx-Class","subtitle":"GitHub repository","main_image_url":"https://github.githubassets.com/images/email/message_cards/header.png","avatar_image_url":"https://github.githubassets.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/Perl5/DBIx-Class"}},"updates":{"snippets":[{"icon":"PERSON","message":"@ribasushi in #129: \u003e Folks, the issue here isn't how to fix the code\r\n\r\nI should have clarified this further: the reason this particular PR was left open was detailed earlier in https://github.com/Perl5/DBIx-Class/pull/129#issuecomment-440952318 :\r\n\u003e ...However - there are a few other places that need a similar update, and as the PR came with no tests of any sort - the spots got missed :(\r\n\r\nEven though there is a different implementation to be released soon which solves the problem by accident, it would still be good to have a test for this. So if time permits **please** contribute a test to go with the minimal changeset by @yewtc above.\r\n\r\nThanks!"}],"action":{"name":"View Pull Request","url":"https://github.com/Perl5/DBIx-Class/pull/129#issuecomment-451107759"}}}</script>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/Perl5/DBIx-Class/pull/129#issuecomment-451107759",
"url": "https://github.com/Perl5/DBIx-Class/pull/129#issuecomment-451107759",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>