<p></p>
<p><b>@ilmari</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/14#discussion_r407208569">lib/DBIx/Class/Schema/Loader/Base.pm</a>:</p>
<pre style='color:#555'>> @@ -2626,8 +2631,8 @@ sub _setup_src_meta {
$self->_dbic_stmt($table_class, 'table', $table->dbic_name);
# Must come after ->table
- if ($is_view and my $view_def = $self->_view_definition($table)) {
- $self->_dbic_stmt($table_class, 'result_source_instance->view_definition', $view_def);
+ if ( $is_view and my $view_def = $self->_view_definition( $table ) and not $self->omit_view_definitions ){
</pre>
<p>There's no point in getting the view definition if we're not going to emit it, so please move the check before the <code>->_view_definition</code> call. Also, please refrain from unrelated whitespace changes.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/14#pullrequestreview-391864893">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AACJ4AVHY33XRAQ2O6DEZZDRMHIC5ANCNFSM4DWLEDPQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AACJ4AX6HT3AHXQFHAMKKOLRMHIC5A5CNFSM4DWLEDP2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOC5NWEPI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/dbsrgits/dbix-class-schema-loader/pull/14#pullrequestreview-391864893",
"url": "https://github.com/dbsrgits/dbix-class-schema-loader/pull/14#pullrequestreview-391864893",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>