<p></p>
<p><b>@robkinyon</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/27#discussion_r776137547">lib/DBIx/Class/Schema/Loader/DBI/Oracle.pm</a>:</p>
<pre style='color:#555'>&gt; @@ -415,12 +415,20 @@ sub _dbh_column_info {
 
 sub _view_definition {
     my ($self, $view) = @_;
-
-    return scalar $self-&gt;schema-&gt;storage-&gt;dbh-&gt;selectrow_array(&lt;&lt;&#39;EOF&#39;, {}, $view-&gt;schema, $view-&gt;name);
+    my $viewdef = scalar $self-&gt;schema-&gt;storage-&gt;dbh
+        -&gt;selectrow_array(&lt;&lt;&#39;EOF&#39;, {}, $view-&gt;schema, $view-&gt;name);
 SELECT text
 FROM all_views
 WHERE owner = ? AND view_name = ?
</pre>
<p dir="auto">I would flip the order of these WHERE clauses so that the parameter lists for both queries are in the same order.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />Reply to this email directly, <a href="https://github.com/dbsrgits/dbix-class-schema-loader/pull/27#pullrequestreview-841167842">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AACJ4AXFDJGGX7NWSSYUC7DUTJ4SRANCNFSM5KV7KJ6A">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&amp;mt=8&amp;pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&amp;referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AACJ4AVTJZBOUR64HHL4GALUTJ4SRA5CNFSM5KV7KJ6KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGIRTHYQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span>&lt;dbsrgits/dbix-class-schema-loader/pull/27/review/841167842</span><span>@</span><span>github</span><span>.</span><span>com&gt;</span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/dbsrgits/dbix-class-schema-loader/pull/27#pullrequestreview-841167842",
"url": "https://github.com/dbsrgits/dbix-class-schema-loader/pull/27#pullrequestreview-841167842",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>