<p dir="auto">This test checks if none of DBIC is loading anything unexpected. It<br>
contains logic to skip over indirect loaders such as base, parent and<br>
Class::C3::Componentised. However, this erroneously skips over direct<br>
dependencies of such classes. In particular, it assigns the MRO::Compat<br>
dependency in Class::C3::Componentised to whatever class it thinks it<br>
loads CCC. Before ad89278 this worked out fine, because it would be<br>
assigned to main, which while meaningless isn't part of DBIx::Class so<br>
ignored. After ad89278, it's assigned to the class that loads CCC, which<br>
is DBIx::Class::Componentised, which is part of DBIC, and hence fails<br>
the test.</p>
<p dir="auto">This test will cause it to not skip on for any BEGIN blocks inside an<br>
indirect loader, therefor the MRO::Compat dependency will correctly be<br>
assigned to Class::C3::Componentised.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/Perl5/DBIx-Class/pull/143'>https://github.com/Perl5/DBIx-Class/pull/143</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/Perl5/DBIx-Class/pull/143/commits/f1e3b0011e4342270adb5bc9860777e8eba1aa70" class="commit-link">f1e3b00</a> Make t/53lean_startup.t robust wrt stacktrace details</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/Perl5/DBIx-Class/pull/143/files">1 file</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/Perl5/DBIx-Class/pull/143/files#diff-caf212d8a7ddb77b549740b3b409a35b74b99f6b29dbbaf98294ad9b84e7d591">t/53lean_startup.t</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/Perl5/DBIx-Class/pull/143.patch'>https://github.com/Perl5/DBIx-Class/pull/143.patch</a></li>
<li><a href='https://github.com/Perl5/DBIx-Class/pull/143.diff'>https://github.com/Perl5/DBIx-Class/pull/143.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/Perl5/DBIx-Class/pull/143">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AACJ4AR22XEVNHU6TJR4JS3U364WDANCNFSM5O2V3VXQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AACJ4ATM4GHDTRR72E6EMN3U364WDA5CNFSM5O2V3VX2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4RB3WRZQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><Perl5/DBIx-Class/pull/143</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/Perl5/DBIx-Class/pull/143",
"url": "https://github.com/Perl5/DBIx-Class/pull/143",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>