<p></p>
<p><b>@hazardv</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/sql-translator/pull/143#discussion_r967244354">lib/SQL/Translator/Producer/Oracle.pm</a>:</p>
<pre style='color:#555'>> - $index_name = quote($index_name, $qf);
- push @index_defs,
- "CREATE INDEX $index_name on $table_name_q (".
- join( ', ', @fields ).
- ")$index_options";
- }
- elsif ( $index_type eq UNIQUE ) {
- $index_name = $index_name ? mk_name( $index_name )
- : mk_name( $table_name, $index_name || 'i' );
- $index_name = quote($index_name, $qf);
- push @index_defs,
- "CREATE UNIQUE INDEX $index_name on $table_name_q (".
- join( ', ', @fields ).
- ")$index_options";
+ elsif ($index_type eq NORMAL or $index_type eq UNIQUE) {
+ warn "CAlling create index with options: " . Dumper($options) . "\n";
</pre>
<p dir="auto">My bad, that warn was there for debugging. I missed it when I was cleaning up. I'll take that out.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/dbsrgits/sql-translator/pull/143#discussion_r967244354">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AACJ4AQH55AON4DNT7EIDWDV5NOQXANCNFSM57BJTHFA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AACJ4AW3H5TSD4DWJXZ3J33V5NOQXA5CNFSM57BJTHFKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOIG36TVY.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><dbsrgits/sql-translator/pull/143/review/1102571991</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/dbsrgits/sql-translator/pull/143#discussion_r967244354",
"url": "https://github.com/dbsrgits/sql-translator/pull/143#discussion_r967244354",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>