<p></p>
<p><b>@rabbiveesh</b> requested changes on this pull request.</p>

<p dir="auto">Hey, I only ran through a little bit, but then I saw that tests are failing on my box.<br>
I suggest you make sure that all tests pass.</p>
<p dir="auto">Here's the list of failing files:<br>
t/54-oracle-sql-diff.t<br>
t/30sqlt-new-diff-mysql.t<br>
t/30sqlt-new-diff-pgsql.t<br>
t/30sqlt-new-diff-sqlite.t<br>
t/51-xml-to-oracle.t<br>
t/51-xml-to-oracle_quoted.t</p><hr>

<p>In <a href="https://github.com/dbsrgits/sql-translator/pull/143#discussion_r982616810">lib/SQL/Translator/Diff.pm</a>:</p>
<pre style='color:#555'>&gt; @@ -92,7 +92,7 @@ sub schema_diff {
     $options ||= {};
 
     my $obj = SQL::Translator::Diff-&gt;new( {
-      %$options,
+      sqlt_args =&gt; $options,
</pre>
<p dir="auto">hey, why did you change this line?<br>
It looks to me like the way it's meant to be used is to passthrough args to SQLT::Diff, one arg of which is the args which are passed down to the inner SQLT instance</p>

<hr>

<p>In <a href="https://github.com/dbsrgits/sql-translator/pull/143#discussion_r982622326">lib/SQL/Translator/Parser/Oracle.pm</a>:</p>
<pre style='color:#555'>&gt; @@ -489,7 +489,17 @@ parens_name_list : &#39;(&#39; NAME(s /,/) &#39;)&#39;
 field_meta : default_val
     | column_constraint
 
-default_val  : /default/i VALUE
+default_val  : 
+    /default/i CURRENT_TIMESTAMP
</pre>
<p dir="auto">just to get this straight: this is special casing CURRENT_TIMESTAMP b/c it's a magic constant in the Oracle grammar, and you don't want SQLT to quote it down the line?</p>
<p dir="auto">If that's the case, I don't know if this is the right place to take care of special casing it here. If you look at the SQLite parser, they special case it in the rule for <code class="notranslate">VALUE</code>, which makes more sense to me.</p>

<hr>

<p>In <a href="https://github.com/dbsrgits/sql-translator/pull/143#discussion_r982624910">lib/SQL/Translator/Parser/Oracle.pm</a>:</p>
<pre style='color:#555'>&gt; @@ -489,7 +489,17 @@ parens_name_list : &#39;(&#39; NAME(s /,/) &#39;)&#39;
 field_meta : default_val
     | column_constraint
 
-default_val  : /default/i VALUE
+default_val  : 
+    /default/i CURRENT_TIMESTAMP
</pre>
<p dir="auto">ah, looking at it again, I see that's exactly what the MySQL parser does. So then I'm okay w/ this, though I think the SQLite way makes more sense</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />Reply to this email directly, <a href="https://github.com/dbsrgits/sql-translator/pull/143#pullrequestreview-1124003436">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AACJ4ARVUJRML422YFNF4YLWARX2HANCNFSM57BJTHFA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AACJ4AVTV3JFWAWLCKL2NY3WARX2HA5CNFSM57BJTHFKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOIL7O43A.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span>&lt;dbsrgits/sql-translator/pull/143/review/1124003436</span><span>@</span><span>github</span><span>.</span><span>com&gt;</span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/dbsrgits/sql-translator/pull/143#pullrequestreview-1124003436",
"url": "https://github.com/dbsrgits/sql-translator/pull/143#pullrequestreview-1124003436",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>