<p></p>
<p><b>@hazardv</b> commented on this pull request.</p>
<hr>
<p>In <a href="https://github.com/dbsrgits/sql-translator/pull/143#discussion_r983642433">lib/SQL/Translator/Diff.pm</a>:</p>
<pre style='color:#555'>> @@ -92,7 +92,7 @@ sub schema_diff {
$options ||= {};
my $obj = SQL::Translator::Diff->new( {
- %$options,
+ sqlt_args => $options,
</pre>
<p dir="auto">At this point, I am not quite sure why I did that. I have been making all of these changes as a result of trying to get a project off the ground using DBIx::Class with an Oracle DB and either DBIx::Class::Schema::Versioned or DBIx::Class::DeploymentHandler for deployment. I know at one point I was running into an issue where schema_diff was getting called directly by a module and when that was happening the sqlt_args that I had passed to the module were getting lost. Changing that line fixed the issue but I hadn't realized how many other things it actually broke. I reverted that and everything in my code seems to be working properly so I am guessing that was related to an issue I was having with DBIx::Class::DeploymentHandler. If I run into the issue again I will do more thorough testing and open a new issue.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/dbsrgits/sql-translator/pull/143#discussion_r983642433">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AACJ4AUQJVN5AJKPVLJXO6LWAWTL5ANCNFSM57BJTHFA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AACJ4AWVQ6HFDQXRKNUUN7LWAWTL5A5CNFSM57BJTHFKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOIMKPBSQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><dbsrgits/sql-translator/pull/143/review/1125445834</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/dbsrgits/sql-translator/pull/143#discussion_r983642433",
"url": "https://github.com/dbsrgits/sql-translator/pull/143#discussion_r983642433",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>