<p></p>
<p dir="auto">I think that the design we settled on is sufficiently encapsulated that we can make changes later.<br>
My first thought is that to handle where the field is really an expression, we should have an <code class="notranslate">expression</code> flag in the <code class="notranslate">extra</code> hash, which the postgres producer will then use to skip quoting even when it's on. Hopefully it won't be too hard to recognize an expression, I haven't worked on the parsers in a while.</p>
<p dir="auto">re <code class="notranslate">uniq</code> - in my implemenation, i actually removed that, b/c the <code class="notranslate">fields</code> of an <code class="notranslate">Index</code> need to be coerced into the new <code class="notranslate">IndexField</code> objects, so that's handled there. Though i see the logic in not allowing duplicates (allows calling code to be lazy in programatically adding column names or whatever).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">&mdash;<br />Reply to this email directly, <a href="https://github.com/dbsrgits/sql-translator/pull/68#issuecomment-1601603518">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AACJ4AVLYJOBSD6FDEA3F2LXMNIETANCNFSM4BOZ5HZA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AACJ4ATPZUTL5TFQOCFSRS3XMNIETA5CNFSM4BOZ5HZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOL53IPPQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span>&lt;dbsrgits/sql-translator/pull/68/c1601603518</span><span>@</span><span>github</span><span>.</span><span>com&gt;</span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/dbsrgits/sql-translator/pull/68#issuecomment-1601603518",
"url": "https://github.com/dbsrgits/sql-translator/pull/68#issuecomment-1601603518",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>