[Dbix-class] [PATCH] SQL::Builder 0.03 - add test and re-work model for JoinGroup

Sam Vilain sam at vilain.net
Mon Nov 7 05:24:27 CET 2005


Sebastian,

As I was converting the "core" of Tangram's SELECT generator to use
SQL::Builder, I found that the JoinGroup code was not tested, and used
(IMHO) the wrong modelling.

I've made a test for the re-modelled behaviour, and "re-implemented" it
based on FromList.

Now, all of Tangram's test suite pass, using SQL::Builder as the core
select builder.  There is still a long way to go before all of Tangram's
Expr core is using SQL::Builder, but I really like how things are going
with it.

I'd like to integrate this change with your code base; let me know if
there's anything you'd like me to change about it before that can
happen.

Sam.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: joingroups-as-fromlist.patch
Type: text/x-patch
Size: 5283 bytes
Desc: not available
Url : http://lists.rawmode.org/pipermail/dbix-class/attachments/20051107/5b2abbc3/joingroups-as-fromlist.bin


More information about the Dbix-class mailing list