[Dbix-class] Proposed patch and tests for a txn_do() method in Schema

Matt S Trout dbix-class at trout.me.uk
Sun Feb 26 00:53:42 CET 2006


On Sat, Feb 25, 2006 at 05:32:32PM -0600, Justin Guenther wrote:
> One possible problem with failed nested rollbacks is if txn_rollback throws
> an exception before resetting $self->{transaction_depth}, it mucks up with
> future transactions. I've modified txn_rollback to wrap everything in an
> eval{} and reset transaction_depth if it fails. Since the only thing I can
> see that could throw an exception is $dbh->rollback, and it never gets
> executed unless transaction_depth is 0, I don't think this is an issue but
> it never hurts to be careful.

Commit bit granted. Get it into trunk :)

-- 
     Matt S Trout       Offering custom development, consultancy and support
  Technical Director    contracts for Catalyst, DBIx::Class and BAST. Contact
Shadowcat Systems Ltd.  mst (at) shadowcatsystems.co.uk for more information

 + Help us build a better perl ORM: http://dbix-class.shadowcatsystems.co.uk/ +



More information about the Dbix-class mailing list