[Dbix-class] inflate_datetime test fails when installing 0.07001

[Christopher H. Laco]

Matt S Trout wrote:
> Christopher H. Laco wrote:
>> Kevin Old wrote:
>>> On 9/6/06, Matt S Trout <dbix-class at trout.me.uk> wrote:
>>>> Try updating Test::More
>>> That did it!  Thanks Matt!
>>
>> As a side note, Test::More isn't always the issue on this error.
>>
>> http://search.cpan.org/src/DROLSKY/DateTime-0.34/Changes
>>
>> - Under Perl 5.6.2 (and presumably 5.6.x), some of the tests
>>   mysteriously failed. I tracked this down to a weird interaction
>>   between DateTime's string overloading and
>>   Test::Builder->cmp_ok(). See RT 19626.
>>
>> I was hoping that fix would fix this issue in 5.8, but it doesn't appear
>> to be as related as I'd hoped.
>>
>> I had the same issues in Handel, so I just bumped up my T::M req to 0.61
>> in META and warned in perl Makefile.PL.
>>
>> I'm even more frustrated that I'd fixed this once in the existing test,
>> but apparently it didn't take as a solution.  :-(
> 
> Maybe we should forciply ->stringify before the comparison?
> 

Fixed and commited to trunk. I was a little hesitant calling ->stringify
directly, but just interpolating the $dt variables did the trick, at
least under 0.54.

-=Chris

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: OpenPGP digital signature
Url : http://lists.rawmode.org/pipermail/dbix-class/attachments/20060906/80d4b599/attachment.pgp