[Dbix-class] [PATCH] Schema::Loader with reserved table name

Brandon Black blblack at gmail.com
Wed Aug 1 14:17:26 GMT 2007


On 8/1/07, Tatsuhiko Miyagawa <miyagawa at gmail.com> wrote:
> On 8/1/07, Matt S Trout <dbix-class at trout.me.uk> wrote:
> > On Wed, Aug 01, 2007 at 12:06:37AM -0700, Tatsuhiko Miyagawa wrote:
> > > The following patch fixes some weird bugs when I used the table name
> > > 'show' with mysql.
> >
> > Wonder if quote_identifier is widely-support yet. If not Schema::Loader
> > should probably switch to using a storage object.
>
> FWIW, quote_identifier was added in DBI 1.21, released in February 2002.
> http://search.cpan.org/dist/DBI/Changes
>

Actually, you're using an outdated version of Schema::Loader.  Ash
patched this problem back in February, and it uses
storage->sql_maker->select, which in turn will do correct quoting if
necessary by setting the quote_char/name_sep storage options.

-- Brandon



More information about the DBIx-Class mailing list