[Dbix-class] New DBIC tarball - test please [Issue resolved]

[John Napiorkowski]

--- "Christopher H. Laco" <claco at chrislaco.com> wrote:

> John Napiorkowski wrote:
> > --- "Christopher H. Laco" <claco at chrislaco.com>
> wrote:
> > 
> >> Christopher H. Laco wrote:
> >>> Christopher H. Laco wrote:
> >>>> Matt S Trout wrote:
> >> http://trout.me.uk/perl/DBIx-Class-0.08003.tar.gz
> >>>>> Quite a few substantial tweaks to fix bugs in
> >> this one, so I'd ask those
> >>>>> of you with decent sized projects with their
> own
> >> test suites to grab it
> >>>>> and give it a quick run down before I ship it
> to
> >> CPAN. We've definitely
> >>>>> fixed a number of irritating bugs but I'm a
> >> trifle worried we might have
> >>>>> introduced new ones hence the delay shipping.
> >>>>>
> >>>> 5x5 for Handel/Mango.
> >>>>
> >>>> -=Chris
> >>> Actually, that's a lie. I'm getting a bunch of
> >> "Undefined value for
> >>> column!" errors during a deploy...but I assume
> >> that's just something
> >>> stupid I'm doing in Mango. The Handel tests
> didn't
> >> gripe.
> >>> -=Chris
> >>>
> >> Nope. Not me.
> >>
> >> Here's my schema:
> >>
> >>>     user_id => {
> >>>         data_type      => 'INT',
> >>>         is_nullable    => 1,
> >>>         is_foreign_key => 1,
> >>>         extras         => {unsigned => 1}
> >>>     },
> >> Here's the call to populate that fails:
> >>
> >>>     $schema->populate('Carts', [
> >>>         [ qw/id user_id created updated/ ],
> >>>         [1,1,$date,$date],
> >>>         [2,undef,$date,$date],
> >>>     ]);
> >> Fails with the error:  Undefined value for
> column!
> >>
> >> So, how do I populate with undef/Null again?
> >> Of course, it used to work.
> >>
> >> -=Chris
> > 
> > This might be me, I made changes to
> $schema->populate
> > to properly support multi create.  Can you run
> your
> > test in 'returns array' mode and let me know if
> that
> > works?  I think it's trouble with my void context
> > support for this.  I'll also check into it.
> > 
> > --john
> 
> Yup, works with:
> 
> >     my @foo = $schema->populate('Carts', [
> >         [ qw/id user_id created updated/ ],
> >         [1,1,$date,$date],
> >         [2,undef,$date,$date],
> >     ]);
> 
> ..which I never do because, I don't really want
> anything back during an
> 'init_schema/populate'...moatly in testing.
> 
> -=Chris

Okay, I checked in an update to this which seems to
fix the trouble.  I was pointlessly throwing an
exception when a column value was undef.  Not sure why
I was doing that.  Anyway I removed that code and
checked in the update and a few tests for the case. 
Let me know if that does the trick. 

--john


 
____________________________________________________________________________________
The fish are biting. 
Get more visitors on your site using Yahoo! Search Marketing.
http://searchmarketing.yahoo.com/arp/sponsoredsearch_v2.php