[Dbix-class] mk_classaccessor now longer available in 08002

[Matt S Trout]

On Fri, Jun 22, 2007 at 03:33:04PM -0400, Christopher Heschong wrote:
> <snip>
> 
> >> >Try adding
> >> >
> >> >sub mk_classaccessor { shift->mk_classdata(@_); }
> >> >
> >> >as a workaround and we'll fix it for 08003.
> >>
> >> I ran into this myself and just added Class::Data::Accessor as a base
> >> class in my code, since that is where the method really comes from.
> >
> > Please next time report the bug :)
> >
> >> Plus if you haven't upgraded your production systems to 08002 yet it
> >> should be compatible on either version.
> >
> > Yes, although the Accessor::Grouped 'inherited type which we're now using
> > for it is a better approach than Class::Data::Accessor and I'd recommend
> > if you're going to change your code you change it to ::Grouped ...
> 
> I thought it was a feature!!  But duly noted... still, is it a good idea
> to rely on methods not provided (or even documented for that matter) by
> the package?

No, it isn't, but when it doesn't cost us anything to do so we don't tend
to break compat even with incidental features like that one - and I consider
"broke compatiblity without gaining anything" to count as a bug :)

C::A::G's 'inherited' type is definitely a better implementation, though
- and respects the package MRO type automatically which is a real boon.

-- 
      Matt S Trout       Need help with your Catalyst or DBIx::Class project?
   Technical Director    Want a managed development or deployment platform?
 Shadowcat Systems Ltd.  Contact mst (at) shadowcatsystems.co.uk for a quote
http://chainsawblues.vox.com/             http://www.shadowcatsystems.co.uk/