[Dbix-class] Re: [Patch] ::Versioned doesn't use sql_maker options

[Tom Lanyon]

On 21/05/2007, at 12:50 PM, Tom Lanyon wrote:

> Hi Jess,
>
> DBIC::Schema::Versioned doesn't pass the SQL Maker options to - 
> >connect (because Storage::DBI drops them from its connect_info).  
> It needs to be in there, especially when you're using table and  
> column names with upper-case chars as PostgreSQL barfs when  
> using ::Versioned currently.
>
> I've attached a patch; with this applied I can use ::Versioned on  
> Postgres as long as I pass the quote_char and name_sep SQL Maker  
> options.
>
> Regards,
> Tom (dec)

Although I've just discovered that the new test for tables  
in ::Versioned::exists() fails if your storage is using quote_chars.  
Updated patch attached to fix this too.

--
Tom Lanyon


-------------- next part --------------
A non-text attachment was scrubbed...
Name: versioned_sqlmaker_opts2.patch
Type: application/octet-stream
Size: 708 bytes
Desc: not available
Url : http://lists.scsys.co.uk/pipermail/dbix-class/attachments/20070521/436ef6a5/versioned_sqlmaker_opts2.obj
-------------- next part --------------