[Dbix-class] SQLA1.50 tests / t/96file_column.t

[Peter Rabbitson]

Dami Laurent (PJ) wrote:
>  
> 
>> -----Message d'origine-----
>> De : Peter Rabbitson [mailto:rabbit+list at rabbit.us] 
>> Envoyé : jeudi, 6. novembre 2008 10:50
>> À : Class user and developer list
>> Objet : Re: [Dbix-class] update on DBIC / SQLA1.50 tests
>>
>> Dami Laurent (PJ) wrote:
>>> Seem to be Win32 problems about files :
>>>
>>> not ok 5 - old storage does not exist # TODO design change required
>>> #   Failed (TODO) test 'old storage does not exist'
>>> #   at t/96file_column.t line 54.
>>>
>>> ok 8 - new content matches
>>> Can't remove file 
>> D:\DOCUME~1\dami\LOCALS~1\Temp\Ty9g5V4LhY\1/File.pm 
>> (Permission denied) at lib/DBIx/Class/InflateColumn/File.pm line 51
>>> Can't remove directory 
>> D:\DOCUME~1\dami\LOCALS~1\Temp\Ty9g5V4LhY\1 (Directory not 
>> empty) at lib/DBIx/Class/InflateColumn/File.pm line 51
>>> ok 9 - storage deleted
>>> not ok 10 - storage does not exist after $rs->delete # TODO 
>> need resultset delete override to delete_all
>>> #   Failed (TODO) test 'storage does not exist after $rs->delete'
>>> #   at t/96file_column.t line 84.
>>>
>> Can you test it _without_ involving SQLA? It shouldn't matter, but I
>> just wanted to make sure. Also please provide the entire output of
>> prove -Ilib t/96file_column.t
>>
>> Thanks
>>
> 
> 
> Output with standard SQLA
> ===========================
> d:\SVN\DBIC\0.08\trunk>prove -Ilib t/96file_column.t 
> prove -Ilib t/96file_column.t 
> t/96file_column....Can't remove file D:\DOCUME~1\dami\LOCALS~1\Temp\fBIe4Si1Ax\1/File.pm (Permission denied) at D:\SVN\DBIC\0.08\trunk\lib/DBIx/Class/InflateColumn/File.pm line 51
> Can't remove directory D:\DOCUME~1\dami\LOCALS~1\Temp\fBIe4Si1Ax\1 (Directory not empty) at D:\SVN\DBIC\0.08\trunk\lib/DBIx/Class/InflateColumn/File.pm line 51
> ok
> All tests successful.
> Files=1, Tests=10,  1 wallclock secs ( 0.02 usr +  0.00 sys =  0.02 CPU)
> Result: PASS
> 
> Output with SQLA1.50
> ====================
> d:\SVN\DBIC\0.08\trunk>perl -Ilib -Id:/SVN/SQLA/1.x/branches/1.50_RC/lib t/96file_column.t 
> perl -Ilib -Id:/SVN/SQLA/1.x/branches/1.50_RC/lib t/96file_column.t 
> 1..10
> ok 1 - created
> ok 2 - storage exists
> ok 3 - filename matches
> ok 4 - file contents matches
> not ok 5 - old storage does not exist # TODO design change required
> #   Failed (TODO) test 'old storage does not exist'
> #   at t/96file_column.t line 54.
> ok 6 - new storage exists
> ok 7 - new filname matches
> ok 8 - new content matches
> Can't remove file D:\DOCUME~1\dami\LOCALS~1\Temp\EjS56AWcxu\1/File.pm (Permission denied) at lib/DBIx/Class/InflateColumn/File.pm line 51
> Can't remove directory D:\DOCUME~1\dami\LOCALS~1\Temp\EjS56AWcxu\1 (Directory not empty) at lib/DBIx/Class/InflateColumn/File.pm line 51
> ok 9 - storage deleted
> not ok 10 - storage does not exist after $rs->delete # TODO need resultset delete override to delete_all
> #   Failed (TODO) test 'storage does not exist after $rs->delete'
> #   at t/96file_column.t line 84.
> 

I think if you run the second test with prove (not with perl like you
do), you will get the same passing result. Both failures are TODOs.