[Dbix-class] '+select'/'+as' is broken when chaining resultsets

[BUCHMULLER Norbert]

On Tue, 28 Oct 2008 00:10:12 +0100 BUCHMULLER Norbert
<norbi.lists at nix.hu> wrote:

> So, the patch for t/88_result_set_column.t contains modifications
> related to 3 different issues:
> 
> 1. a new test for chained search() and '+select'/'+as'
> 2. a new test for a $rs->get_column() for a nonexistent column
> 3. $rs->get_column() calls replaced with $rs->first->get_column() calls
> 
> Would it help if I send the changes broken up into 3 (stacked) patches?
> (So that you can review the changes separately.)

I think that they will make your work easier, so I did not wait for your
answer. Here they are:

1. dbic_chained_plusselect_test.diff

2. dbic_resultsetcolumn_nonexistent_column_test.diff

3. dbic_resultsetcolumn_nonexistent_column_fix.diff

norbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dbic_chained_plusselect_test.diff
Type: text/x-patch
Size: 1009 bytes
Desc: not available
Url : http://lists.scsys.co.uk/pipermail/dbix-class/attachments/20081028/f2105b25/dbic_chained_plusselect_test.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dbic_resultsetcolumn_nonexistent_column_test.diff
Type: text/x-patch
Size: 612 bytes
Desc: not available
Url : http://lists.scsys.co.uk/pipermail/dbix-class/attachments/20081028/f2105b25/dbic_resultsetcolumn_nonexistent_column_test.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dbic_resultsetcolumn_nonexistent_column_fix.diff
Type: text/x-patch
Size: 1507 bytes
Desc: not available
Url : http://lists.scsys.co.uk/pipermail/dbix-class/attachments/20081028/f2105b25/dbic_resultsetcolumn_nonexistent_column_fix.bin