[Dbix-class] deployment_statements in list context
Peter Rabbitson
rabbit+dbic at rabbit.us
Thu Dec 24 09:00:16 GMT 2009
Daniel Westermann-Clark wrote:
> Hi,
>
> Until 0.08113, the return value of
> DBIx::Class::Storage::DBI::deployment_statements depended on list or
> scalar context because that's how SQLT worked. Revision 7815
> introduced some error handling, but also forced scalar context.
>
> Would anyone object to forcing list context instead? I don't know how
> many people use deployment_statements (instead of just deploy), but
> returning a giant string doesn't seem terribly useful.
Yes I would. The deployment statements sometimes differ in list vs
scalar context. And when you dump stuff into a file you want a giant
string which is terminated correctly.
So based on your test the real fix:
http://dev.catalyst.perl.org/svnweb/bast/revision?rev=8163
Cheers!
More information about the DBIx-Class
mailing list