[Dbix-class] Fwd: how to determine column is inflatable?

[Carl Franks]

Hi,

This seems to have been warnocked, could someone point out if there's
anything I could do to help get it committed?

Since I originally sent this, the inflation test files have been moved
around, so the patch won't apply cleanly - is it worth me sending a
new patch against trunk?

Cheers,
Carl



---------- Forwarded message ----------
From: Carl Franks <fireartist at gmail.com>
Date: 2009/5/21
Subject: Re: how to determine column is inflatable?
To: dbix-class mailing list <dbix-class at lists.scsys.co.uk>


2009/1/29 Carl Franks <fireartist at gmail.com>:
> Is it okay to use $result_source->column_info('name')->{_inflate_info}
> to test whether a column is inflatable / deflatable?
> It seems a bit too reliant on internals, to me.
>
> Or should there be a has_inflatable_column('name') method?
>
> (and is that what it should be called? do we really also need a
> 'has_deflatable_column' too?)
>
> If someone makes a call, I'll write up a patch for it.

Attached is a patch against 0.08/trunk -r6358

set_inflatable_column() already had code to explicitly support calling
it on non-inflatable columns.
This patch adds tests for that.

It also changes get_inflatable_column() to also support being called
on non-inflatable columns, plus tests.

Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: get_inflated_column.patch
Type: application/octet-stream
Size: 1848 bytes
Desc: not available
Url : http://lists.scsys.co.uk/pipermail/dbix-class/attachments/20090901/07=
dc0769/get_inflated_column.obj