[Dbix-class] DBIx::Class::Tree::Fast

[vdg]

On Tue, Aug 3, 2010 at 7:32 PM, fREW Schmidt <frioux at gmail.com> wrote:

>
> Comments and ideas very welcome off course.
>>
>
> This is indeed very interesting.  I look forward to reading the code more
> carefully later.  On first perusal I *did* notice two things though:
>
> 1) What is locale_h from POSIX?
>

Nothing related to this module. Thanks for spoting that :-)


> 2) Did you realize you used // which is in 5.10 and greater only?
>

Yes, but you are right, it should be easy to use 5.8 compatible code. I'll
change that.


> 3) you should use $rs->current_source_alias instead of 'me.'
>

Thanks again. Glad to learn this exists.

Valentin.


>
> Other than that it looks well written to me.
>
> --
> fREW Schmidt
> http://blog.afoolishmanifesto.com
>
> _______________________________________________
> List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
> IRC: irc.perl.org#dbix-class
> SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
> Searchable Archive:
> http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.scsys.co.uk/pipermail/dbix-class/attachments/20100804/042=
86abe/attachment.htm