[Dbix-class] 0.08198_01 heading for CPAN - rollback to fix prefetch issues

[Greg Hill]

I'm back and finally able to work on this.  I'm writing up some tests, =

but so far they all pass against master, which I believe is the =

pre-rollback version, correct?    I guess I'm going to have to dig more =

into the exact cause, since it was routinely failing on pretty simple =

prefetch scenarios in our actual codebase.  How do I test against the =

rolled-back version once I can get a failure scenario on master?  Is =

that a separate branch?

Greg

P.S. =

http://git.shadowcat.co.uk/gitweb/gitweb.cgi?p=3Ddbsrgits/DBIx-Class.git;a=
=3Dblob;f=3DCONTRIBUTING;h=3D586ec4c6fe47b1635b5755a1d0435c1d7731a9a5;hb=3D=
HEAD =

the git clone mentioned there asks for a password.  I ended up just =

cloning master readonly (git clone =

git://git.shadowcat.co.uk/dbsrgits/DBIx-Class.git) and will provide a =

patch if I can get the tests sorted out rather than pushing a branch up.


On 08/02/2012 10:15 AM, Greg Hill wrote:
> I will try to get a test case written up tomorrow; fighting a problem =

> that's blocking our next release going to staging.
>
> I never heard anything about the other problem I was encountering.  =

> Did anyone have an idea on how to make the delete_related work when =

> the related class has a default prefetch?  This used to work, but even =

> after the rollback, it no longer does.  It generates an invalid query =

> for mysql.  Or maybe it's explicitly no longer supported?  I could =

> probably change it to a search_related->delete_all if I had to.
>
> Greg
>
> On 08/02/2012 06:26 AM, Arthur Axel 'fREW' Schmidt wrote:
>> Any chance we could get an ETA on this test?  the 0.08199 release is
>> blocking on it.
>>
>> On 08/01/2012 09:35 AM, Arthur Axel 'fREW' Schmidt wrote:
>>> Greg,
>>>
>>> Could you please write a test that fails on 0.08198 but passes on
>>> 0.08198_01?  DBIC has a quite fully fleshed out test schema so I doubt
>>> it should be difficult.  We *do* want to add the features in eventually
>>> that were taken out in the dev rel so unless we get tests for these
>>> regressions they will regress again :)
>>>
>>> On 07/25/2012 04:50 PM, Greg Hill wrote:
>>>> That fixed both problems I reported earlier today.
>>>>
>>>> Thanks!
>>>>
>>>> Greg
>>>>
>>>> On 07/25/2012 01:38 PM, Jess Robinson wrote:
>>>>> Hi all,
>>>>>
>>>>> As there have been several reports of issues with prefetch on 0.08198,
>>>>> we've rolled back a change to the collapsing code (prefetched data
>>>>> into related objs) and released as a dev release.
>>>>>
>>>>> Please test this against code with issues and report back.
>>>>>
>>>>> Jess
>>>>>
>>>>> _______________________________________________
>>>>> List:http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
>>>>> IRC: irc.perl.org#dbix-class
>>>>> SVN:http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
>>>>> Searchable Archive:
>>>>> http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk
>>>> _______________________________________________
>>>> List:http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
>>>> IRC: irc.perl.org#dbix-class
>>>> SVN:http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
>>>> Searchable Archive:
>>>> http://www.grokbase.com/group/dbix-class@lists.scsys.co.uk
>>
>>
>> _______________________________________________
>> List:http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
>> IRC: irc.perl.org#dbix-class
>> SVN:http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
>> Searchable Archive:http://www.grokbase.com/group/dbix-class@lists.scsys.=
co.uk
>
>
>
>
> _______________________________________________
> List: http://lists.scsys.co.uk/cgi-bin/mailman/listinfo/dbix-class
> IRC: irc.perl.org#dbix-class
> SVN: http://dev.catalyst.perl.org/repos/bast/DBIx-Class/
> Searchable Archive: http://www.grokbase.com/group/dbix-class@lists.scsys.=
co.uk


-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.scsys.co.uk/pipermail/dbix-class/attachments/20120813/6b9=
712c4/attachment.htm