[Dbix-class] exception_action fail after DBIC upgrade
rabbit+dbic at rabbit.us
Mon Jan 21 17:49:25 GMT 2013
On Mon, Jan 21, 2013 at 09:26:24PM +0400, Konstantin A. Pustovalov wrote:
> On 20.01.2013 23:11, Peter Rabbitson wrote:
> >On Mon, Dec 10, 2012 at 08:09:48PM +1100, Peter Rabbitson wrote:
> >>On Mon, Dec 10, 2012 at 12:30:52PM +0400, Konstantin A. Pustovalov wrote:
> >>>Hello list!
> >>>I'm using exception_action feature. Some of my tests fail after
> >>>upgrading 0.08196 -> 0.08204
> >>>I have reduced test case to the following: http://paste.scsys.co.uk/217862
> >>>exception_action is never get called in my setup. Am I doing
> >>>something wrong or is it intended behavior?
> >>Unintended breakage due to lack of tests - so when a refactor broke it
> >>things went unnoticed. Can you please add several tests like the one
> >>attached to t/34exception_action.t, and we will fix it for the next
> >> https://github.com/dbsrgits/dbix-class/blob/master/t/34exception_action.t
> >Any word on these tests I asked you about?
> Sorry for being silent. Loong russian holidays, you know )
> But I have investigated a little. DBIC seems to not notice the
> exception if it (exeption) stringifies to zero length string. That
> was OK for my code since all error info was coded into exception
> type. Till DBIC upgrade. The fix was to add some message to all
> exceptions. Should I still pull test to fixate 0.08196 behavior?
Yes please. While this is ultimately a problem with your code (an
exception may *never* stringify to "", read `perldoc -f eval` for the
exact reason why), I still want to get DBIC to handle it correctly.
More information about the DBIx-Class